Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug1619724 Alert name should not be in table #6176

Closed
wants to merge 1 commit into from
Closed

Bug1619724 Alert name should not be in table #6176

wants to merge 1 commit into from

Conversation

kingsham
Copy link

No description provided.

@yogmel
Copy link
Contributor

yogmel commented Mar 26, 2020

Hi, thanks for working on this.
This, however, is not the correct solution.
You should remove the entire row in the Alert Table and add it on top, maintaining its style and layout.

The file you should be modifying is https://github.com/mozilla/treeherder/blob/master/ui/perfherder/alerts/AlertTable.jsx#L203 as shown in the bug description.

Also, do make sure all tests pass, as written in Treeherder documentation.

@sarah-clements
Copy link
Contributor

@kingsham Are you planning to finish this pr?

@kingsham
Copy link
Author

kingsham commented Aug 18, 2020 via email

@sarah-clements
Copy link
Contributor

I need some help with it

Ok, what do you need help with? :) Please explain in detail what you are stuck on and what you've tried that didn't work.

@sarah-clements
Copy link
Contributor

This was actually dealt with in #6860.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kingsham @yogmel @sarah-clements @sham-k