Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1656036 - Stop trying to ingest Fenix pushes for branches that we… #6669

Merged
merged 1 commit into from Jul 30, 2020

Conversation

armenzg
Copy link
Collaborator

@armenzg armenzg commented Jul 29, 2020

… don't support

There are Fenix tasks coming down the ingestion pipeline for PRs and non-master branches.

This avoids raising MissingPushException and retrying ingesting the task multiple times.

You can test this locally with this command:

./manage.py ingest task --task-id LKSAc7NLTIWQIo3g-XTybw

@armenzg armenzg added the python label Jul 29, 2020
@armenzg armenzg self-assigned this Jul 29, 2020
@armenzg armenzg temporarily deployed to treeherder-fenix-pushes-l15kqc July 29, 2020 18:18 Inactive
@armenzg armenzg temporarily deployed to treeherder-fenix-pushes-l15kqc July 29, 2020 18:30 Inactive
@armenzg armenzg temporarily deployed to treeherder-prototype July 29, 2020 19:00 Inactive
@armenzg
Copy link
Collaborator Author

armenzg commented Jul 29, 2020

I'm running this on prototype.

@armenzg
Copy link
Collaborator Author

armenzg commented Jul 29, 2020

With fewer workers prototype is catching up faster:
image

@armenzg
Copy link
Collaborator Author

armenzg commented Jul 29, 2020

I pushed one more time for tasks that do not use those env variables. For instance: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/LKSAc7NLTIWQIo3g-XTybw

Copy link
Contributor

@sarah-clements sarah-clements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

… don't support

There are Fenix tasks coming down the ingestion pipeline for PRs and non-master branches.

This avoids raising MissingPushException and retrying ingesting the task multiple times.

You can test this locally with this command:

```shell
./manage.py ingest task --task-id LKSAc7NLTIWQIo3g-XTybw
```
@armenzg armenzg merged commit cb16205 into master Jul 30, 2020
@armenzg armenzg deleted the fenix_pushes branch July 30, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants