Bug 1171575 - Remove unused cancel_all function from controller.js

[vaibhavmagarwal]

[tojon]

Drive by.. just to ensure we've encompassed everything for removal? :)
https://github.com/mozilla/treeherder/search?utf8=%E2%9C%93&q=cancel

[vaibhavmagarwal]

I am not sure about other areas, since I have not read through all of TH code :)
But I have confidence, that this function is not used.

[edmorley]

Whilst this function is unused, I wonder if in fact this is the better location for the similar functions that are used? ie: in the future should we support "cancel all" for non-buildbot? If so, the functionality needs to be more generic than just in buildapi.js

I'll defer to @camd on this, since iirc he wrote the cancel job code :-)

[vaibhavmagarwal]

The cancelAllJobs() function that is currently being used is in jobs.js:

treeherder/ui/js/controllers/jobs.js

Line 193 in 09a5a1d

$scope.cancelAllJobs = function(revision) {

[camd]

After taking a look (gosh, we have a lot of cancelAll type of funcitons) it looks like the one @vaibhavmagarwal mentions in jobs.js is the main one. It, in turn calls other model/service functions to do its work.

But this one in question was added long ago by me and, I think, never used. Having it in the plugins/controller.js would be the wrong place anyway.

Good find, @vaibhavmagarwal ! :)