Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant word "Version" in TTF version string #26

Closed
jfkthame opened this issue Mar 29, 2018 · 0 comments
Closed

Redundant word "Version" in TTF version string #26

jfkthame opened this issue Mar 29, 2018 · 0 comments

Comments

@jfkthame
Copy link
Collaborator

I notice that the .ttf file ends up with a version string (name id 5) that reads:

<namerecord nameID="5" platformID="3" platEncID="1" langID="0x409">
  Version Version 0.3.1
</namerecord>

I guess this is because https://github.com/mozilla/twemoji-colr/blob/master/Gruntfile.js#L22 prefixes the word "Version" to the number, but then the webfont generator must be automatically doing the same thing.

So presumably just removing this from the gruntfile should fix it. (Untested.)

timdream added a commit that referenced this issue Mar 29, 2018
Fix bug #26 and update version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants