Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Twemoji 15.1.0 (Emoji 15.1) #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

win98se
Copy link
Contributor

@win98se win98se commented Feb 22, 2024

Will fix #73, #72, #69 & #68; Also includes workarounds for jdecked/twemoji@dbb2a10#commitcomment-124376242.

Notes:

@win98se
Copy link
Contributor Author

win98se commented Mar 8, 2024

Caution: The fs.rm method is only compatible with Node.js version >=14. Recommended versions are >=16 (in Node.js versions 14 and 15, npm install throws a bunch of warnings and errors, although the make step runs fine).

@win98se win98se changed the title Update to Twemoji 15.0.3 (Emoji 15.0) Update to Twemoji 15.1.0 (Emoji 15.1) Mar 28, 2024
@win98se
Copy link
Contributor Author

win98se commented Mar 28, 2024

Twemoji 15.1.0 is out ~12 hours ago; Updated accordingly.

@Tricertops
Copy link

@win98se Hi, I’m wondering if you could help me with building the font on your branch. I’m getting this error without any indication of where it’s happening:

npm run grunt webfont

> twemoji-colr@0.7.0 grunt
> grunt webfont

Running "webfont:Twemoji" (webfont) task
Fatal error: CreateListFromArrayLike called on non-object
make: *** [build/raw-font/Twemoji Mozilla.ttf] Error 3

Is there an npm version mismatch or some dependency is broken there? Did you try running this recently?

@CoelacanthusHex
Copy link

@win98se Hi, I’m wondering if you could help me with building the font on your branch. I’m getting this error without any indication of where it’s happening:

npm run grunt webfont

> twemoji-colr@0.7.0 grunt
> grunt webfont

Running "webfont:Twemoji" (webfont) task
Fatal error: CreateListFromArrayLike called on non-object
make: *** [build/raw-font/Twemoji Mozilla.ttf] Error 3

Is there an npm version mismatch or some dependency is broken there? Did you try running this recently?

I met the same issue when packaging it in archlinuxcn.

@Nerixyz
Copy link

Nerixyz commented Jun 26, 2024

Works fine for me on Ubuntu 22.04 with Node 21 when running npm i && make.

@CoelacanthusHex
Copy link

Works fine for me on Ubuntu 22.04 with Node 21 when running npm i && make.

My nodejs version is 22.3.0 and npm version is 10.8.1. I'm on Arch Linux.

@CoelacanthusHex
Copy link

I see grunt-webfonts use fontforge, its version is 20230101-4.

@win98se
Copy link
Contributor Author

win98se commented Jun 29, 2024

I have no problems building with Ubuntu 24.04, Node.js 22.3.0 and npm 10.8.1.

@Tricertops Please mention your build environment (such as operating system/distro, versions of Node.js and npm) as well.

@win98se
Copy link
Contributor Author

win98se commented Jun 30, 2024

@CoelacanthusHex Please try to install the packages, fontforge and python-setuptools -
sudo pacman -S python-setuptools fontforge
Then retry building.

@Tricertops Please also try the above steps I've mentioned if you're also using Arch Linux.

@CoelacanthusHex
Copy link

@CoelacanthusHex Please try to install the packages, fontforge and python-setuptools - sudo pacman -S python-setuptools fontforge Then retry building.

Ok. python-setuptools is missing.

@Tricertops Please also try the above steps I've mentioned if you're also using Arch Linux.

@Tricertops
Copy link

@win98se Thanks! It seems like the package python-setuptools was missing for me as well!

I’m on macOS 14.5, node.js 22.3.0, npm 10.8.1, python 3.12.

However, I’m also facing another issue that I tried to fix, but didn’t find a way:

Traceback (most recent call last):
  File "[redacted]/TwemojiMozilla/fixDirection.py", line 1, in <module>
    import fontforge
ModuleNotFoundError: No module named 'fontforge'
make: *** [build/Twemoji Mozilla.ttf] Error 1

I definitely have fontforge package installed, but for some reason this script can’t locate it. When I skip the fixDirection.py step of the build, the rest of the make runs fine and I’m getting the TTF file on the expected location.

Do you have any ideas? I’m not really skilled in python 🤷🏻‍♂️

@win98se
Copy link
Contributor Author

win98se commented Jul 2, 2024

I definitely have fontforge package installed, but for some reason this script can’t locate it.

Ah, it seems to be an environment problem. In your case, try to edit the Makefile file, with line 37 reading $(PYTHON) fixDirection.py $(RAW_FONT_TEMPORARY) changed to fontforge -lang=py -script fixDirection.py $(RAW_FONT_TEMPORARY) (replacing the term $(PYTHON) with fontforge -lang=py -script). Finally, rerun the make step.

@Tricertops
Copy link

@win98se That works, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twemoji 15 Update
4 participants