Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention how to install uniffi-bindgen if we fail to execute it. #277

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

mhammond
Copy link
Member

Also updates other instructions to reflect the name is uniffi_bindgen
rather than uniffi-bindgen.

Also updates other instructions to reflect the name is `uniffi_bindgen`
rather than `uniffi-bindgen`.
@mhammond mhammond requested a review from rfk September 11, 2020 06:02
Copy link
Collaborator

@rfk rfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, but also, I wonder if we should change the crate name so that it is in fact the more idiomatic uniffi-bindgen...

@rfk rfk merged commit 6ebfe61 into mozilla:main Sep 11, 2020
@mhammond
Copy link
Member Author

I wonder if we should change the crate name so that it is in fact the more idiomatic uniffi-bindgen...

I assumed that situation was forced on us - +1 to unifiiing that if possible 🥴

@rfk
Copy link
Collaborator

rfk commented Sep 12, 2020

Oh no, it looks like hyphens-versus-underscores is a whole thing and now that I've published with the underscore, we might not be able to use the hyphen.

For example, linking to the crate as uniffi-bindgen works as far as crates.io is concerned, but attempting to cargo install uniffi-bindgen fails as you note above. Bleh.

@mhammond mhammond deleted the print-cargo-install branch March 27, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants