-
Notifications
You must be signed in to change notification settings - Fork 6
Generate the src/*.rdf files from a template #60
Conversation
No clue if this is a good idea, but it saves having to keep the addon version in sync in 3 places and just generates the Plus copies the generated |
I updated the README.md, but I guess we could even go one step further and make an npm script wrapper which does these 2 steps as a single command:
Where we could theoretically create the following npm sauce: "scripts": {
"release": "npm version patch && gulp build"
} And then running |
@@ -7,7 +7,7 @@ | |||
<em:type>2</em:type> | |||
|
|||
<em:unpack>false</em:unpack> | |||
<em:version>1.1</em:version> | |||
<em:version><%= version %></em:version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now package.json#version
is now the only variable that gets interpolated into the install/update RDF files. Makes templating and everything else a lot simpler.
@pdehaan Great idea, I'm totally happy to merge this. As far as pushing the two steps into a script, we might actually do any of Let me know if you want to mess with adding a release script, otherwise I'll merge this. Nice work ^_^ |
@@ -1,3 +1,4 @@ | |||
node_modules | |||
dist | |||
*.log | |||
src/*.rdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohhhh, you generate them from the template, ok
Turns out, that may not be super straight forward, but I'm investigating a few options:
|
@6a68 I'm happy to merge this as-is, and do the release scripts in a separate PR, or I can just |
@pdehaan Sure, let's merge and follow-on! |
Generate the src/*.rdf files from a template
No description provided.