This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Issue 27 moz action urls #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to improve the display of these items on the iframe side, but the addon will now actually switch to the tab, if this kind of item is selected. We haven't specifically discussed it, but there are also 'keyword' moz-action URLs; this change should handle those properly, too. Fixes #27.
jaredhirsch
force-pushed
the
issue-27-moz-action-urls
branch
from
0e30304
to
daed09b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nchapman FYI, this change will fix the addon side of the moz-action:switchtab behavior, but we'll need a separate fix for the iframe.