Skip to content
This repository has been archived by the owner on Dec 5, 2018. It is now read-only.

Adds utility script to prepopulate cache (closes #28). #100

Merged
merged 2 commits into from
Apr 26, 2016
Merged

Adds utility script to prepopulate cache (closes #28). #100

merged 2 commits into from
Apr 26, 2016

Conversation

chuckharmston
Copy link
Contributor

@chuckharmston chuckharmston commented Apr 18, 2016

  • Remove coverage from run.sh
  • Test for recommendation.tasks.task_recommend.make_key
  • Test for prepopulate.explode
  • Test for prepopulate.queue
  • Test for prepopulate.wikipedia
  • Test for prepopulate.alexa

@chuckharmston
Copy link
Contributor Author

screen shot 2016-04-18 at 5 05 46 pm

This is pretty neat, though.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2ac4cbb on chuckharmston:28-prepopulate into 5a0c1ff on mozilla:master.

@chuckharmston chuckharmston changed the title [wip] Adds utility script to prepopulate cache (closes #28). Adds utility script to prepopulate cache (closes #28). Apr 25, 2016
@chuckharmston
Copy link
Contributor Author

No longer WIP!

r? @6a68

@jaredhirsch
Copy link
Member

@chuckharmston Looks good to me overall, tests passing for me locally.

Any reason we aren't using the Alexa US top 1000? We're just targeting en-US for the initial release.

Needs a rebase, then feel free to merge.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7330bdd on chuckharmston:28-prepopulate into 6af094b on mozilla:master.

@chuckharmston
Copy link
Contributor Author

I used what @nchapman suggested in the bug; easy to tweak. I'd file a followup bug, but in a quick search I couldn't find any US-specific raw data sources.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants