Skip to content

Commit

Permalink
hgserver: update tests for 4.8 compatibility (Bug 1501686) r=gps
Browse files Browse the repository at this point in the history
The tests under `hgserver/` pass, with the exception of some
extra output under 4.8. There is also a test which checks for
`mozreview-ldap-associate` which is EOL and failing under
4.7 as well, this commit removes that section.

`test-bookmarks-replication.t` is still intermittently
failing due to a bookmark not showing up as replicated
on the first call to the `json-bookmarks` webcommand -
subsequent calls show it exists so I suspect there is
a race condition there.

Differential Revision: https://phabricator.services.mozilla.com/D10390

--HG--
extra : moz-landing-system : lando
  • Loading branch information
cgsheeh committed Oct 31, 2018
1 parent addbce3 commit 135ac13
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
3 changes: 2 additions & 1 deletion hgserver/tests/test-obsolescence-server.t
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ Pulling should get the obsmarkers
added 1 changesets with 0 changes to 1 files
1 new obsolescence markers
obsoleted 1 changesets
new changesets 5217e2ac5b15 (hg44 !)
new changesets 5217e2ac5b15 (no-hg48 !)
new changesets 5217e2ac5b15 (1 drafts) (hg48 !)
(run 'hg update' to get a working copy)
$ hg debugobsolete
ba1c6c2be69c46fed329d3795c9d906d252fdaf7 5217e2ac5b1538d1630aa54377056dbfab270508 0 (*) {*'user': 'Test User <someone@example.com>'} (glob)
Expand Down
6 changes: 0 additions & 6 deletions hgserver/tests/test-pash-auth.t
Original file line number Diff line number Diff line change
Expand Up @@ -364,12 +364,6 @@ hgAccountEnabled=FALSE shows account disabled message
bug (http://tinyurl.com/njcfhma) and request hg access be restored
for hgdisabled@example.com.
mozreview-ldap-associate isn't enabled on hgssh

$ ssh -T -F ssh_config -i key1 -l user1@example.com -p $HGPORT $SSH_SERVER mozreview-ldap-associate
mozreview-ldap-associate command not available
[1]

Failure to connect to LDAP mirror locks us out
What happens here is nscd caches the valid passwd entry lookup for the user.
However, the SSH key lookup via LDAP fails and this manifests as no public keys
Expand Down

0 comments on commit 135ac13

Please sign in to comment.