Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentence Collector: ensure valid ending punctuation for uploaded sentences #1815

Closed
MichaelNMaggs opened this issue Feb 14, 2019 · 1 comment

Comments

@MichaelNMaggs
Copy link

MichaelNMaggs commented Feb 14, 2019

I see from recent sentence validations that quite a few texts are being uploaded with non-standard terminal punctuation (particularly commas) such as

Robbery, bribery, fraud,

These are causing differences between reviewers, with some such as myself ignoring the final comma as it makes no difference to the reader, while others reject the text as invalid. This particular example has been accepted on a two to one vote. Many seem to be going the same way, but we really should not need to be voting on an issue which could so easily be dealt with by the sentence upload filter.

It would be very helpful if, at a minimum, the upload filter could block texts that end with a comma. To be slightly more sophisticated, the English filter could block uploads having any terminal punctuation which is neither a full stop, a question mark, an exclamation mark, a closing parenthesis, or a single or double quotation mark.

@Gregoor
Copy link
Contributor

Gregoor commented Feb 15, 2019

Can you repost this issue to the sentence-collector issues? Thanks!

@Gregoor Gregoor closed this as completed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants