test: throw for unexpected config error

mozilla · Nov 5, 2017 · 737dd74 · 737dd74
1 parent af2e9a9
commit 737dd74
Showing 1 changed file with 23 additions and 21 deletions.
diff --git a/tests/unit/test.program.js b/tests/unit/test.program.js
@@ -536,18 +536,19 @@ describe('program.main', () => {
       })
       .then(makeSureItFails())
       .catch((error) => {
-        if (!(error instanceof UsageError)) {
-          const {capturedMessages} = consoleStream;
-          consoleStream.stopCapturing();
-
-          assert.match(error.message, /some error/);
-          assert.ok(
-            capturedMessages.some(
-              (message) => message.match(/some error/)
-          ));
-          sinon.assert.notCalled(fakeApplyConfigToArgv);
-          sinon.assert.notCalled(fakeProcess.exit);
+        const {capturedMessages} = consoleStream;
+        consoleStream.stopCapturing();
+
+        if (error instanceof UsageError) {
+          throw error;
         }
+
+        assert.match(error.message, /some error/);
+        assert.ok(capturedMessages.some(
+          (message) => message.match(/some error/)
+        ));
+        sinon.assert.notCalled(fakeApplyConfigToArgv);
+        sinon.assert.notCalled(fakeProcess.exit);
       });
   });
 
@@ -619,17 +620,18 @@ describe('program.main', () => {
       })
       .then(makeSureItFails())
       .catch((error) => {
-        if (!(error instanceof UsageError)) {
-          const {capturedMessages} = consoleStream;
-          consoleStream.stopCapturing();
-
-          assert.match(error.message, /some error/);
-          assert.ok(
-            capturedMessages.some(
-              (message) => message.match(/some error/)
-          ));
-          sinon.assert.notCalled(fakeProcess.exit);
+        const {capturedMessages} = consoleStream;
+        consoleStream.stopCapturing();
+
+        if (error instanceof UsageError) {
+          throw error;
         }
+
+        assert.match(error.message, /some error/);
+        assert.ok(capturedMessages.some(
+          (message) => message.match(/some error/)
+        ));
+        sinon.assert.notCalled(fakeProcess.exit);
       });
   });
 });