Skip to content

Commit

Permalink
fix: Prevent opening the privacy policy page on web-ext run (#1220)
Browse files Browse the repository at this point in the history
  • Loading branch information
rpl authored and kumar303 committed Jan 19, 2018
1 parent 6b993d2 commit cdcc945
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/firefox/preferences.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ const prefsFirefox: FirefoxPreferences = {
'browser.selfsupport.url': 'https://localhost/selfrepair',
// Disable Reader Mode UI tour
'browser.reader.detectedFirstArticle': true,

// Set the policy firstURL to an empty string to prevent
// the privacy info page to be opened on every "web-ext run".
// (See #1114 for rationale)
'datareporting.policy.firstRunURL': '',
};

const prefs = {
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/test-firefox/test.preferences.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ describe('firefox/preferences', () => {
assert.equal(prefs['devtools.debugger.remote-enabled'], true);
// This is a Firefox only pref.
assert.equal(prefs['devtools.chrome.enabled'], true);
// This is a Firefox only pref that we set to prevent Firefox
// to open the privacy policy info page on every "web-ext run".
assert.equal(prefs['datareporting.policy.firstRunURL'], '');
});

it('gets Fennec prefs with some defaults', () => {
Expand Down

0 comments on commit cdcc945

Please sign in to comment.