Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest.json parser too strict #1285

Closed
freaktechnik opened this issue Mar 13, 2018 · 2 comments
Closed

manifest.json parser too strict #1285

freaktechnik opened this issue Mar 13, 2018 · 2 comments

Comments

@freaktechnik
Copy link
Contributor

What is the current behavior?

The manifest.json is parsed using the json-parser package, which emits nicer errors, but does not support comments. This was discovered with an error when trying to sign an extension with comments in the manifest by @AntoineTurmel.

What is the expected or desired behavior?

The parser should be able to handle comments in the manifest.json file.

@freaktechnik
Copy link
Contributor Author

While that is generally true, it does not apply to manifest.json and messages.json files. We sadly have to expect comments in them.

See also https://browserext.github.io/browserext/#pre-parsing

@tommai78101
Copy link

tommai78101 commented Mar 15, 2018

Ugh, I accidentally deleted my previous comment. Original comment:

Comments are not valid in all JSON files.

https://plus.google.com/+DouglasCrockfordEsq/posts/RK8qyGVaGSr


I see, so in this case, only manifest.json and messages.json files are exempt from it? I do not see in the current article saying the messages.json should also ignore comments. Or maybe I'm looking in the wrong place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants