Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking link with target="_blank" in Android doesn't work PLUS it breaks debugging and whole add-on #1592

Closed
Juraj-Masiar opened this issue Apr 30, 2019 · 1 comment · Fixed by #1594
Assignees
Projects

Comments

@Juraj-Masiar
Copy link

Is this a feature request or a bug?

Bug

What is the current behavior?

See the video:
https://www.youtube.com/watch?v=RxWO3wykTLA

But basically this is what is happening:

  1. create any addon page
  2. insert any link on that page with target="_blank" attribute
  3. open the add-on page in Android
  4. click the link
  5. link is NOT opened and add-on get's broken, debugging doesn't work anymore

What is the expected or desired behavior?

Link should get opened.

Version information (for bug reports)

  • Firefox version:
  • Your OS and version:
  • Paste the output of these commands:
node --version && npm --version && web-ext --version

v12.0.0
6.8.0
3.0.0

@Rob--W Rob--W self-assigned this Apr 30, 2019
@Rob--W
Copy link
Member

Rob--W commented Apr 30, 2019

This is because the browser.link.open_newwindow pref is overridden, changed from default 3 to 2.

Unfortunately, there is also a bug in web-ext run for Android that --pref=browser.link.open_newwindow=3 does not override the pref.

So as a work-around, visit about:config and reset the browser.link.open_newwindow preference (there is a Reset button that will restore the value of 3).

PS. Thanks for the detailed video. It made it much easier to see and debug the issue.

Rob--W added a commit to Rob--W/web-ext that referenced this issue Apr 30, 2019
@rpl rpl added this to To do in 3.1.0 via automation Jul 1, 2019
@rpl rpl moved this from To do to Done in 3.1.0 Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
3.1.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants