Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot start extension on Android if name contains a slash #2119

Closed
Rob--W opened this issue Jan 11, 2021 · 3 comments · Fixed by #2222
Closed

Cannot start extension on Android if name contains a slash #2119

Rob--W opened this issue Jan 11, 2021 · 3 comments · Fixed by #2222
Projects

Comments

@Rob--W
Copy link
Member

Rob--W commented Jan 11, 2021

Is this a feature request or a bug?

Bug

What is the current behavior?

Create an extension and put a slash in the name field in manifest.json
Then run web-ext run -t firefox-android .... to run the extension.
What happens is that the browser starts, but web-ext quits, ending with:

Starting org.mozilla.fenix...

Waiting for org.mozilla.fenix Remote Debugging Server...
Make sure to enable "Remote Debugging via USB" from Settings -> Developer Tools if it is not yet enabled.

Building web extension from /path/to/extension/with/slash/in/name

s: Invalid filename template "{name}-{version}.zip". Filename "Name with /slash-1.zip" should not contain a path

What is the expected or desired behavior?

Fenix starts with the extension.

Version information (for bug reports)

  • Firefox version: Not relevant
  • Your OS and version: Not relevant
  • Paste the output of these commands:
node --version && npm --version && web-ext --version

v15.5.0
6.14.10
5.2.0

@Rob--W
Copy link
Member Author

Rob--W commented Jan 13, 2021

This is a regression, regressed by #1900.

@defkev
Copy link

defkev commented Apr 9, 2021

Can confirm.

run --filename|-n didn't work and now seems to have been completely dropped...

web-ext 6.0.0 w/ npm v14.16.1

@ximex
Copy link

ximex commented Jan 5, 2023

I have this bug with web-ext@7.4 with run and build cmd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
6.1.0
Done
Development

Successfully merging a pull request may close this issue.

3 participants