Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove npm engine upper bound to fix EBADENGINE warning when installing web-ext using npm v7 #2271

Closed
rpl opened this issue Jun 18, 2021 · 1 comment · Fixed by #2146
Closed
Assignees
Projects

Comments

@rpl
Copy link
Member

rpl commented Jun 18, 2021

Due to incompatibilities between the package lock file format generated by npm v7, any CI jobs running for nodejs version that are including npm v6 as the pre-installed npm version where failing as soon as renovatebot did upgrade the lockfile to lockfileVersion 2.

As a short term workaround, we added an upper bound on the npm engine in the wbe-ext package.json file (see ##2145).

With the npm upper bound set, installing web-ext using npm v7 will print an EBADENGINE warning:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'web-ext@6.1.0',
npm WARN EBADENGINE   required: { node: '>=12.0.0', npm: '>=6.9.0 <7.0.0' },
npm WARN EBADENGINE   current: { ... }
npm WARN EBADENGINE }

It doesn't prevent web-ext from being installed successfully, but it may be confusing for the users (e.g. because it may give the impression that web-ext isn't compatible with npm v7, which is not really the case, the package-lock.json does not matter while installing the package released on npm and it is not even included in the assets released on npm).

We should workaround the CI job issue as part of the circleci config and remove the upper bound from the npm engine configured in the web-ext package.json.

@rpl rpl self-assigned this Jun 18, 2021
@rpl rpl linked a pull request Jun 18, 2021 that will close this issue
1 task
@rpl
Copy link
Member Author

rpl commented Jun 18, 2021

Closed by #2146

@rpl rpl closed this as completed Jun 18, 2021
@rpl rpl added this to Done in 6.2.0 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
6.2.0
Done
Development

Successfully merging a pull request may close this issue.

1 participant