Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update npm to v7 #2146

Merged
merged 2 commits into from
Jun 18, 2021
Merged

chore(deps): update npm to v7 #2146

merged 2 commits into from
Jun 18, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 3, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
npm (source) >=6.9.0 <7.0.0 -> >=6.9.0 <8.0.0 age adoption passing confidence

Release Notes

npm/cli

v7.18.1

Compare Source

v7.18.1 (2021-06-17)

BUG FIXES

v7.18.0

Compare Source

v7.17.0

Compare Source

v7.16.0

Compare Source

v7.15.1

Compare Source

BUG FIXES
DEPENDENCIES
  • c4fc03e9e
    @npmcli/arborist@2.6.1
    • fixes reifying deps with mismatching version ranges between
      actual and virtual trees
  • 9159fa62a
    libnpmexec@1.2.0

v7.15.0

Compare Source

FEATURES
BUG FIXES
DOCUMENTATION
DEPENDENCIES
  • 7b56bfdf3
    cacache@15.2.0:
    • feat: allow fully deleting indices
    • feat: add a validateEntry option to compact
    • chore: lint
    • chore: use standard npm style release scripts
  • dbbc151a3
    npm-audit-report@2.1.5:
    • fix(exit-code): account for null auditLevel default (#​46)
  • 5b2604507
    chore(package-lock): update devDependencies
    (@​Gar)
AUTOMATION

v7.14.0

Compare Source

FEATURES
BUG FIXES
DEPENDENCIES

v7.13.0

Compare Source

FEATURES
DEPENDENCIES

v7.12.1

Compare Source

BUG FIXES
DEPENDENCIES
  • 285976fd1
    @npmcli/arborist@2.4.4
    • fix(reify): properly save spec if prerelease
  • f9f24d17c
    libnpmexec@1.1.1
    • fix(add): Specify 'en' locale to String.localeCompare
  • cb9f17499
    glob@7.1.7
    • force 'en' locale in string sorting
  • 24b4e4a41
    ignore-walk@3.0.4
    • Avoid locale-specific sorting issues
  • 1eb7e5c7d
    @npmcli/arborist@2.4.3
    • guard against locale-specific sorting
  • a6a826067
    npm-packlist@2.2.2:
    • fix(sort): avoid locale-dependent sorting issues

v7.12.0

Compare Source

FEATURES
BUG FIXES
DEPENDENCIES
  • d01ce5e13
    libnpmexec@1.1.0:
    • feat: add walk up dir lookup to satisfy local bins
  • 81c1dfaaa
    @npmcli/arborist@2.4.2:
    • fix(add): save packages in the right place
    • fix(reify): do not clean up nodes with no parent
    • fix(audit): support alias specs & root package names
  • 87c2303ea
    @npmcli/git@2.0.9:
    • fix(clone): Do not allow git replacement objects by default
  • 99ff40dff
    npm-packlist@2.2.0:
    • feat(npmignore): Do not force include history, changelogs, notice
    • fix(package.json): add missing bin/index.js to files

v7.11.2

Compare Source

BUG FIXES
DEPENDENCIES
  • fb79d89a0
    tap@15.0.6
  • ce3820043
    @npmcli/arborist@2.4.1
    • fix: prevent and eliminate unnecessary duplicates
    • fix: support resolvable partial intersecting peerSets
DOCUMENTATION

v7.11.1

Compare Source

DEPENDENCIES
DOCUMENTATION
  • efdd7dd44
    Remove unused and incorrectly documented --always-auth config definition
    (@​isaacs)

v7.11.0

Compare Source

FEATURES
BUG FIXES
DOCUMENTATION
DEPENDENCIES

v7.10.0

Compare Source

FEATURES
DEPENDENCIES
  • f1e6743a6
    libnpmversion@1.2.0
    • feat(retrieve-tag): retrieve unannotated git tags
    • fix(retrieve-tag): use semver to look for semver
  • 3b476a24c
    @npmcl/git@2.0.8
    • fix(git): do not use shell when calling git
  • dfcd0c1e2
    #​3069
    tap@15.0.2
DOCUMENTATION

v7.9.0

Compare Source

FEATURES
DEPENDENCIES

v7.8.0

Compare Source

FEATURES
BUG FIXES
DEPENDENCIES
  • 61da39beb
    @npmcli/config@2.1.0
    • feat(config): add support for envExport:false
  • fb095a708
    @npmcli/arborist@2.3.0:
    • #​2896 Provide currentEdge in
      ERESOLVE if known, and address self-linking edge case.
    • Add/remove dependencies to/from workspaces when set, not root project
    • Only reify the portions of the dependency graph identified by the
      workspace configuration value.
    • Do not recursively chown the project root path.

v7.7.6

Compare Source

BUG FIXES
DEPENDENCIES
  • a28f89572
    libnpmversion@1.1.0
    • fix reading script-shell config on npm version lifecycle scripts
  • 03734c29e
    npm-packlist@2.1.5
    • fix packaging bundledDependencies
  • 80ce2a019
    @npmcli/metavuln-calculator@1.1.1
    • fix error auditing package documents with missing dependencies

v7.7.5

Compare Source

BUG FIXES
TESTS

v7.7.4

Compare Source

BUG FIXES

v7.7.3

Compare Source

BUG FIXES

v7.7.2

Compare Source

BUG FIXES
DEPENDENCIES

v7.7.1

Compare Source

BUG FIXES

v7.7.0

Compare Source

FEATURES
BUG FIXES
DOCUMENTATION
DEPENDENCIES
  • 7b5606b93
    @npmcli/arborist@2.2.9
  • f76e7c21f
    pacote@11.3.1
    • increases tarball compression level
  • 4928512bc
    semver@7.3.5
    • fix handling prereleases/ANY ranges in subset
  • 1924eb457
    libnpmversion@1.0.12
    • fix removing undescored-prefixed package.json properties in npm version
  • 916623056
    @npmcli/run-script@1.8.4
    • fix expanding windows-style environment variables
  • a8d0751e4
    npm-pick-manifest@6.1.1
    • fix running packages with a single executable binary with npm exec
  • af7eaac50
    hosted-git-info@4.0.1
  • f52c51db1
    @npmcli/config@2.0.0

v7.6.3

Compare Source

DOCUMENTATION
DEPENDENCIES
  • 57ed390d6
    @npmcli/arborist@2.2.8
    • Respect link deps when calculating peerDep sets

v7.6.2

Compare Source

BUG FIXES
DEPENDENCIES
  • 7f470b5c2
    @npmcli/arborist@2.2.7
    • fix(install): Do not revert a file: dep to version on bare name re-install
  • e9b7fc275
    libnpmdiff@2.0.4
    • fix(diff): Gracefully handle packages with prepare script
  • c7314aa62
    byte-size@7.0.1
  • 864f48d43
    pacote@11.3.0

v7.6.1

Compare Source

BUG FIXES
DOCUMENTATION
DEPENDENCIES

v7.6.0

Compare Source

FEATURES
DEPENDENCIES
  • b9fa7e32a
    chore(package-lock): resetdeps and eslint@7.20.0
    (@​wraithgar)
  • 28d036ae9
    arborist@2.2.5
    • fix: hidden lockfiles were not respected on Node v10.0-10.12
DOCUMENTATION

v7.5.6

Compare Source

BUG FIXES
DOCS
DEPENDENCIES
  • f3ae6ed0d
    read-package-json@3.0.1, read-package-json-fast@2.0.2
  • 9b311fe52
    #​2736 @npmcli/arborist@2.2.4:
    • Do not rely on underscore fields in package.json files
    • Do not remove global packages when updating by name
    • Keep yarn.lock and package-lock.json more in sync

v7.5.5

Compare Source

BUG FIXES
DEPENDENCIES
TESTS
DOCUMENTATION

v7.5.4

Compare Source

BUG FIXES
DEPENDENCIES
TESTS
DOCUMENTATION

v7.5.3

Compare Source

BUG FIXES
DEPENDENCIES
  • 3294fed6f
    pacote@11.2.5
    • prevent infinite recursion in git dep preparation
  • 0f7a3a87c
    read-package-json-fast@2.0.1
    • avoid duplicating optionalDependencies as dependencies in package.json
  • 6f46b0f7f
    init-package-json@2.0.2
  • df4f65acc
    @npmcli/arborist@2.2.0
  • 7038c2ff4
    @npmcli/run-script@1.8.2
  • 54cd4c87a
    libnpmversion@1.0.8
  • 9ab36aae4
    graceful-fs@4.2.5
  • e1822cf27
    @npmcli/installed-package-contents@1.0.7

v7.5.2

Compare Source

BUG FIXES
DEPENDENCIES

v7.5.1

Compare Source

BUG FIXES
DEPENDENCIES
  • 7e4e88e93
    @npmcli/arborist@2.1.1, pacote@11.2.4
    • Properly raise ERESOLVE errors on root dev dependencies
    • Ignore ERESOLVE errors when performing git dep 'prepare' scripts
    • Always reinstall packages that are explicitly requested
    • fix global update all so it actually updates things
    • Install bins properly when global root is a link
      (@​isaacs)
DOCUMENTATION

v7.5.0

Compare Source

FEATURES

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@rpl
Copy link
Member

rpl commented Feb 3, 2021

the green light from the CI jobs may seem tempting, but this PR doesn't upgrade the lockfileVersion and so at the moment if we do merge this we would very likely just trigger #2145 again (which we just fixed, exactly by specifying in the package.json the supported npm version range to be strictly < v7).

We are going to leave this open but unmerged (and tagged with a state: do not merge label) until we are sure that we would not trigger that same issue.

@wagnerand
Copy link
Member

@rpl I believe the inconsistencies come from the fact that our CI uses npm v6 which understands lock files v1 only, and renovate was using npm v7 (which creates lock files v2). Restricting npm.engine in package.json was the right fix as per https://docs.renovatebot.com/node/#configuring-which-version-of-npm-renovate-uses.

So, in order to unblock this PR, we need to make sure CI uses npm v7 first.

rpl pushed a commit that referenced this pull request Mar 12, 2021
By default, `npm` ships with `node`. When targeting Node.js v12+, the targeted NPM versions should
also be upgraded.

- Node.js v12.0.0 (minimum supported by `web-ext`) ships with NPM v6.9.0.
- Node.js v14.16.0 (current LTS) ships with NPM v6.14.11.
- Node.js v15.11.0 (current version) ships with NPM v7.6.0.
- https://nodejs.org/en/download/releases/

Changes

- Updates versions mentioned in `README.md`.
- The NPM version in `engines` in `package.json` has had the lower range limit updated to match
  the NPM version shipped with Node.js v12.
- The NPM version upper range limit is due to #2146 and must be kept for now. Note that
  this yields `EBADENGINE` warnings when using NPM v7.0.0+, which can be ignored.
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #2146 (497a1ea) into master (c866678) will not change coverage.
The diff coverage is n/a.

❗ Current head 497a1ea differs from pull request most recent head 5bff970. Consider uploading reports for the commit 5bff970 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2146   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          32       32           
  Lines        1699     1699           
=======================================
  Hits         1697     1697           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c866678...5bff970. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
6.2.0
Done
Development

Successfully merging this pull request may close these issues.

Remove npm engine upper bound to fix EBADENGINE warning when installing web-ext using npm v7
3 participants