Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show the command in error messages #994

Closed
kumar303 opened this issue Jul 6, 2017 · 5 comments
Closed

Don't show the command in error messages #994

kumar303 opened this issue Jul 6, 2017 · 5 comments

Comments

@kumar303
Copy link
Contributor

kumar303 commented Jul 6, 2017

Is this a feature request or a bug?

feature

What is the current behavior?

If you encounter an error, web-ext will always prefix the command to the error message, like:

$ web-ext run --target firefox-android -v --android-device FA6AX0301736

run: UsageError: Select one of the packages using --firefox-apk

What is the expected or desired behavior?

I don't think we need to show the command. It can just be:

$ web-ext run --target firefox-android -v --android-device FA6AX0301736

UsageError: Select one of the packages using --firefox-apk

The command name is added as a prefix here. When removed, it should still be added for verbose mode, like:

log.debug(`Command executed: ${cmd}`);

Originally, the command prefix was added to help in bug reports but really we always need a verbose log for debug reports anyway. Also, you can look at the command line to seed what command was run.

@wagnerand
Copy link
Member

Mentor: @kumar303

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

@Divya063
Copy link

Is this issue still available?

@kumar303
Copy link
Contributor Author

Hi @Divya063, yes it is.

@Divya063
Copy link

@kumar303 There is a pull request referring to this issue

@kumar303
Copy link
Contributor Author

@Divya063 oh, wow, sorry about that but thanks for pointing out the pull request! 😬 I have merged it. Thank you for the patch, @tsl143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants