Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent the privacy policy info page to be opened on every run #1220

Merged
merged 1 commit into from
Jan 19, 2018
Merged

fix: Prevent the privacy policy info page to be opened on every run #1220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/firefox/preferences.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ const prefsFirefox: FirefoxPreferences = {
'browser.selfsupport.url': 'https://localhost/selfrepair',
// Disable Reader Mode UI tour
'browser.reader.detectedFirstArticle': true,

// Set the policy firstURL to an empty string to prevent
// the privacy info page to be opened on every "web-ext run".
// (See #1114 for rationale)
'datareporting.policy.firstRunURL': '',
};

const prefs = {
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/test-firefox/test.preferences.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ describe('firefox/preferences', () => {
assert.equal(prefs['devtools.debugger.remote-enabled'], true);
// This is a Firefox only pref.
assert.equal(prefs['devtools.chrome.enabled'], true);
// This is a Firefox only pref that we set to prevent Firefox
// to open the privacy policy info page on every "web-ext run".
assert.equal(prefs['datareporting.policy.firstRunURL'], '');
});

it('gets Fennec prefs with some defaults', () => {
Expand Down