Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web-ext should look for the extension id in browser_specific_settings and fallback to applications #1974

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

rpl
Copy link
Member

@rpl rpl commented Jul 24, 2020

Fixes #1901

This PR includes and supersedes #1944

  • the first patch contains a squashed version of feat: Add support for browser_specific_settings #1944 as submitted by the author (I did preserve Lusito as the author of that patch because it did change enough from the PR it was originally based on),
  • the second patch applies some small tweaks to:
    • better match Firefox behavior (and some additional test case to cover the expected behaviors)
    • fix some new flow typecheck errors (due to the updated flow version)
    • small tweaks suggested in the last round of review comments

This PR also enable the optional chaining support in the flow config file.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fd4916e on rpl:fix/browser-specific-support into a6eb2a9 on mozilla:master.

@rpl rpl merged commit 2e03e74 into mozilla:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-ext ignores manifest browser_specific_settings.gecko.id field
4 participants