Skip to content
This repository has been archived by the owner on Apr 1, 2019. It is now read-only.

Implement Into<cookie::Cookie> for Cookie #33

Merged
merged 1 commit into from Jun 1, 2016

Conversation

dlrobertson
Copy link

@dlrobertson dlrobertson commented May 27, 2016

This is largely for servo/servo#10826.

Implement Into<cookie::Cookie> (where cookie is cookie-rs). Then impl Serialize and Deserialize in cookie-rs.

Either way, we need one common way of representing a cookie... As long as it isn't oatmeal raisin 😄

CC @asajeffrey


This change is Reviewable

@jgraham
Copy link
Member

jgraham commented May 27, 2016

I am… not thrilled about requring serde here, at least unless you serdeify the whole crate. I think maybe implementing Into<Cookie> would be better if that will give you what you need.

@asajeffrey
Copy link

@dlrobertson dlrobertson changed the title Impl serialize for Cookie Implement Into<cookie::Cookie> for Cookie May 28, 2016
@dlrobertson
Copy link
Author

Updated

@jgraham
Copy link
Member

jgraham commented Jun 1, 2016

Reviewed 2 of 3 files at r2.
Review status: 2 of 3 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jgraham
Copy link
Member

jgraham commented Jun 1, 2016

Reviewed 1 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jgraham jgraham merged commit 2ee8645 into mozilla:master Jun 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants