Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Error processing your package #14

Closed
minj opened this issue Sep 27, 2017 · 29 comments · Fixed by #31
Closed

Error processing your package #14

minj opened this issue Sep 27, 2017 · 29 comments · Fixed by #31
Labels

Comments

@minj
Copy link

minj commented Sep 27, 2017

Link to package

@javierjavier
Copy link

I'm seeing this as well.

@Folyd
Copy link

Folyd commented Feb 26, 2018

same thing to me.

@thdoan
Copy link

thdoan commented Mar 20, 2018

Ditto for me (using Chrome's "pack extension" function). I got a slightly different message though: "Error processing your package: Failed to unpack file."

@schellmax
Copy link

Same problem here, 'Failed to unpack file'.
Very simple extension, was using Chrome's 'pack extension' feature as mentioned by @thdoan
Chrome on Mac, Version 68.0.3440.106 (Official Build) (64-bit)

@mu-ms
Copy link

mu-ms commented Sep 22, 2018

I have the same problem. Do you have any hint, what to do?

@jausions
Copy link

CRX file downloaded directly from the Chrome Web Extension Developer Dashboard.

Got the message :

Error processing your package
Failed to unpack file.

@benchesh
Copy link

benchesh commented Nov 8, 2018

Seeing this as well. Tried with multiple crx files downloaded from the Chrome Web Store

@techslogi
Copy link

Yep, happening here as well.

@RobertJGabriel
Copy link

Still happening too :'(

@rusty686
Copy link

Same happened to me today

@ron-dadon-samanage
Copy link

Same here...

@Emmortal451
Copy link

Same thing happening to me this morning

@vargasa
Copy link

vargasa commented Dec 16, 2018

@Emmortal451 As a workaround make a zip file with your source code instead of packing it with chrome, then upload the zip file to the website

@eazrael
Copy link

eazrael commented Dec 22, 2018

Still the same error. Zipping manually did not change anything.

@jarodsmk
Copy link

Bump, occurred with me too.

CRX created through Chrome's Extension page, selected the root extension folder and private key (.pem), uploaded it and got the same error.

Also tried zipping the extensions root directory, I get this:

image

Any ideas?

@jarodsmk
Copy link

jarodsmk commented Apr 30, 2019

Cloned the project and after a lengthy time of getting it up and running, I eventually found:

image

I suspect that might be causing all the other issues here. Will try dig some more.

@Slluxx
Copy link

Slluxx commented May 3, 2019

+1

@jarodsmk
Copy link

jarodsmk commented May 10, 2019

Been looking into this further.

Made sure that my CRX is built properly and has the correct magic number, and noticed something else:

image

According to the following links, the CRX version was bumped from 2 to 3, and the unzip-crx package used here still checks for version 2, or fails with the above error.

https://chromium.googlesource.com/chromium/src/+/b8bc9f99ef4ad6223dfdcafd924051561c05ac75%5E%21/
https://bugs.chromium.org/p/chromium/issues/detail?id=720092

Where to check the version in your uncompressed CRX:

image

Currently looking into a quick workaround by either updating unzip-crx or just switching to unzip-crx-3:
https://www.npmjs.com/package/unzip-crx-3?

EDIT:
Apologies looks like unzip-crx does support CRX3
https://github.com/peerigon/unzip-crx/blob/da7c616820e582b6d214e1c6ce6129940882a288/src/index.js#L43

There are some other dependencies that only support CRX (2) however.

EDIT 2:
unzip-crx could have an outdated npm version/hasn't been published. The changes are only currently on their master branch for CRX3

@jarodsmk
Copy link

jarodsmk commented May 10, 2019

Looks like one culprit, a dependency of this project and addons-linter is crx-parser:
https://github.com/shyiko/node-crx-parser/blob/17d02f0d931a113a626f75283b745d85f2597d93/src/index.js#L6

Also, seems like only recent Chrome versions stopped support for CRX (2):
http://chromium.2324630.n4.nabble.com/crx-CRX3-Announcement-td30991.html

@caitmuenster
Copy link
Contributor

Thanks for the report & investigation! Unfortunately, the engineer who was maintaining this project has since left Mozilla. I'll check in with some folks to see if we can find resources to fix this.

@sean-adams
Copy link

sean-adams commented Jun 2, 2019

FYI I've submitted a PR for crx-parser that fixes this issue:
shyiko/node-crx-parser#2

But as @jarodsmk noticed, this issue is actually upstream of webext-compat-tool in addons-linter, where I've also opened an issue:
mozilla/addons-linter#2621

@jarodsmk
Copy link

jarodsmk commented Jun 3, 2019

FYI I've submitted a PR for crx-parser that fixes this issue:
shyiko/node-crx-parser#2

Nicely done - I ended up writing my own crx-parser based off of:

They both had some interesting code for handling the versions, I wanted to clean mine up and get permission from the 2 devs above to have a CRX parser to rule them all (ie. allow the code to be easily expanded in the future for other possible version), but haven't gotten around to it with an office move happening and what not.

I noticed the repo by @shyiko hadn't been maintained in a couple years and was hesitant to add a PR due to time constraints on my own project

@sean-adams
Copy link

Nice @jarodsmk - I like the idea of one parser to rule them all 🙂 There's some movement on node-crx-parser so I'm going to try to help see that through but if I can contribute at all to your work let me know!

@jarodsmk
Copy link

jarodsmk commented Jun 3, 2019

@sean-adams It seems there's a definite need for a well maintained CRX parser for other projects to use, I'll start coding something up in the next night or 2 and keep in contact 😃

@mastef
Copy link

mastef commented Aug 5, 2019

So it didn't work for me with .zip files or .crx version 3 files. I managed to generate a .crx version 2 files with this script: https://github.com/rangle/augury/blob/master/crxmake.sh - and then everything went smooth.

Just make sure you comment out some of the processes that don't apply to your extension. E.g. do_build and exit at line 92.

@Rob--W
Copy link
Member

Rob--W commented Aug 5, 2019

@mastef CRX3 files should work, and have been tested according to #31 (comment)

If you have an extension that fails to be parsed, please share it.

@mastef
Copy link

mastef commented Aug 5, 2019

@Rob--W I tried a .zip file, I tried a .crx file that was downloaded from the Chrome extensions webstore, nothing worked. Once I made a version 2 .crx file everything worked.

This is the extension I was testing for compatibility : https://chrome.google.com/webstore/detail/tab-manager-plus-for-chro/cnkdjjdmfiffagllbiiilooaoofcoeff

@Rob--W
Copy link
Member

Rob--W commented Aug 5, 2019

@mastef I downloaded the extension that you provided (CRX3 format) (with my crxviewer), and successfully uploaded it to https://www.extensiontest.com/ . Are you sure that you've downloaded the correct version of the extension?

@mastef
Copy link

mastef commented Aug 6, 2019

@Rob--W That's very weird, I've tried with the exactly same CRX3 file as yesterday and now it's suddenly working. Before that it was throwing the same errors as reported here ( hence I found this thread ). I had the same error as in the screenshot of @jarodsmk - "Error processing your package" and an empty "Report Details" section.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.