Skip to content

Commit

Permalink
fix: Fix downloads schemas
Browse files Browse the repository at this point in the history
- Alphabetically sort keys
- Add `"fallbackToNoCallback": true` to `open` and `show`
  because these methods do currently not take any callbacks in Chrome:
  https://developer.chrome.com/extensions/downloads#method-open
  https://developer.chrome.com/extensions/downloads#method-show
- Chrome has a `downloads.acceptDanger` method, but Firefox does not,
  so this is not included in the schema.
  • Loading branch information
Rob--W authored and rpl committed Jun 15, 2018
1 parent fc25bd3 commit 5977888
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions api-metadata.json
Expand Up @@ -219,11 +219,11 @@
}
},
"downloads": {
"download": {
"cancel": {
"minArgs": 1,
"maxArgs": 1
},
"cancel": {
"download": {
"minArgs": 1,
"maxArgs": 1
},
Expand All @@ -237,7 +237,8 @@
},
"open": {
"minArgs": 1,
"maxArgs": 1
"maxArgs": 1,
"fallbackToNoCallback": true
},
"pause": {
"minArgs": 1,
Expand All @@ -257,7 +258,8 @@
},
"show": {
"minArgs": 1,
"maxArgs": 1
"maxArgs": 1,
"fallbackToNoCallback": true
}
},
"extension": {
Expand Down

0 comments on commit 5977888

Please sign in to comment.