Skip to content

Commit

Permalink
fix(test): fixed unexpected messages in new test case based on review…
Browse files Browse the repository at this point in the history
… comments
  • Loading branch information
rpl committed Mar 26, 2018
1 parent 87e76c5 commit ecc7c92
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/test-runtime-onMessage.js
Expand Up @@ -176,15 +176,15 @@ describe("browser-polyfill", () => {
return setupTestDOMWindow(fakeChrome).then(window => {
const listenerReturnsFalse = sinon.spy((msg, sender, sendResponse) => {
waitPromises.push(Promise.resolve().then(() => {
sendResponse("Ignored sendReponse callback on returned Promise");
sendResponse("Ignored sendReponse callback on returned false");
}));

return false;
});

const listenerReturnsValue = sinon.spy((msg, sender, sendResponse) => {
waitPromises.push(Promise.resolve().then(() => {
sendResponse("Ignored sendReponse callback on returned Promise");
sendResponse("Ignored sendReponse callback on non boolean/thenable return values");
}));

// Any return value that is not a promise should not be sent as a response,
Expand Down

0 comments on commit ecc7c92

Please sign in to comment.