Minify compile time constants during build #142
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
SEND_RESPONSE_DEPRECATION_WARNING
would end up as:in both the built and minified distribution files, which adds unnecessary start-up overhead where the
/\s+/g
regular expression has to be compiled and executed, followed by trimming the string.This instead performs such a process during the build, which provides a few milliseconds of start-up time savings per extension which uses this polyfill, which adds up for a lot of extensions, especially ones with an event page, where the polyfill has to be loaded and executed every time the extension handles an event.