Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent a webpage document element to be detected as the Extension API object #153

Merged
merged 5 commits into from Aug 15, 2018
Merged

fix: Prevent a webpage document element to be detected as the Extension API object #153

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8cbd6e
fix: Prevent a webpage document element to be detected as the Extensi…
rpl Jul 21, 2018
57da1c3
chore: applied changes based on the last review comments
rpl Aug 15, 2018
a6f31b2
chore: applied a small tweak to fix a test unit failure due to the la…
rpl Aug 15, 2018
de4adf5
chore: added integration for API object detection in background page …
rpl Aug 15, 2018
17536d2
chore: minor tweaks on tests based on last round of review comments
rpl Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/browser-polyfill.js
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
"use strict";

if (typeof browser === "undefined") {
if (typeof browser === "undefined" || browser instanceof window.Node) {
const CHROME_SEND_MESSAGE_CALLBACK_NO_RESPONSE_MESSAGE = "The message port closed before a response was received.";
const SEND_RESPONSE_DEPRECATION_WARNING = `
Returning a Promise is the preferred way to send a reply from an
Expand Down
7 changes: 7 additions & 0 deletions test/fixtures/index.html
View file
Open in desktop
Expand Up @@ -6,5 +6,12 @@
</head>
<body>
<h1>Browser Polyfill Test Page</h1>

<!--
The following two DOM elements ensure that the polyfill doesn't detect the
globals defined for these DOM element ids as the Extensions API objects.
-->
<div id="browser"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add another <div id="browser"></div> to demonstrate the issue that I mentioned above.

<div id="chrome"></div>
</body>
</html>