test(integration): Use node for running test scripts #167
Conversation
|
I haven't reviewed the PR in detail, but I approve of the motivation behind it. |
ExE-Boss
force-pushed
the
test/use-node-for-scripts
branch
from
9877353
to
f2c30bb
Compare
|
The primary difference is the removal of Edge‑specific code. Then there’s the ESLint configuration improvements and better Windows compatibility. |
ExE-Boss
force-pushed
the
test/use-node-for-scripts
branch
from
f2c30bb
to
4c5f402
Compare
| for (const extensionDirName of extensions) { | ||
| test(`${description} (test extension: ${extensionDirName})`, async (tt) => { | ||
| let timeout; | ||
| let driver; | ||
| let server; | ||
| let tempDir; | ||
|
|
||
| const browser = process.env.TEST_BROWSER_TYPE; | ||
|
|
||
| if (skip) { |
ExE-Boss
force-pushed
the
test/use-node-for-scripts
branch
from
829a229
to
8d44ec7
Compare
There was a problem hiding this comment.
@ExE-Boss Thanks, this looks good to me, "configuring eslint to allow just module as a valid global" sounds like a reasonable enough approach, as an alternative to disable the eslint rule on those two lines.
I would like to apply the following small additional changes to the .eslintrc files (now that we have two specific ones in the src and test directories):
- remove
browserandwebextensionsenvs from the top level .eslintrc - add
browserandwebextensionsenvs to src/.eslintrc and test/.eslintrc
But it is just a small optional nit, and so I'm going to merge this as it is and apply these two small changes in a follow up.
This adds @rpl’s changes from #163 that convert the bash scripts to node scripts, making testing easier on Windows (the platform I use for development).
review?(@Rob--W, @rpl)