Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Revamp sharing modal #40

Closed
toolness opened this issue Feb 12, 2015 · 6 comments
Closed

Revamp sharing modal #40

toolness opened this issue Feb 12, 2015 · 6 comments

Comments

@toolness
Copy link
Contributor

This is what it looks like in reference.html:

screen shot 2015-02-12 at 1 31 37 pm

I guess doing a lot of the social network options will mean hosting the image somewhere first.

@davidascher
Copy link

For the purpose of demo, we can just make an unauthed POST-to-s3 endpoint.

On Thu, Feb 12, 2015 at 10:34 AM, Atul Varma notifications@github.com
wrote:

This is what it looks like in reference.html
http://xmatthewx.github.io/webmaker-addons/reference.html:

[image: screen shot 2015-02-12 at 1 31 37 pm]
https://cloud.githubusercontent.com/assets/124687/6174271/a9607b8a-b2bb-11e4-8c0c-70d921548149.png

I guess doing a lot of the social network options will mean hosting the
image somewhere first.


Reply to this email directly or view it on GitHub
#40.

@xmatthewx
Copy link
Contributor

Would be nice to auto copy url to clipboard and notify user.

@xmatthewx
Copy link
Contributor

The webmaker icon could pop open your modal with him.

@xmatthewx
Copy link
Contributor

Ha. Auto correct. Html, not him.

@xmatthewx
Copy link
Contributor

For demo, share could include 3 buttons. Text labels are fine. View Image, Copy Link, Share as a Page.

@toolness
Copy link
Contributor Author

Ok, I've got this done for the demo... don't have it uploading to S3 or anything but can add that later, which I filed #43 for.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants