Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

[MIGRATED] Add icon component #1584

Closed
k88hudson opened this issue Apr 28, 2015 · 3 comments
Closed

[MIGRATED] Add icon component #1584

k88hudson opened this issue Apr 28, 2015 · 3 comments
Labels
enhancement help wanted

Comments

@k88hudson
Copy link
Contributor

We need this to support multiple colours, maintain consistent size etc.
@thisandagain thisandagain added this to the Alpha 2/2 milestone Apr 29, 2015
@k88hudson k88hudson changed the title Add icon font Add icon component Apr 30, 2015
@k88hudson
Copy link
Contributor Author

I would love to have an icon font, but a component will do for now.

@Pomax
Copy link
Contributor

Pomax commented May 1, 2015

Why not both? We can make an <Icon> component that serves up "whatever works" while we work on it, so we can use a JSX syntax like <Icon type="eyeball" /> and have that either generate an svg image or, once we find a nice one, text span with an icon font.

@thisandagain thisandagain modified the milestones: Beta 1/2, Alpha 2/2 May 5, 2015
@thisandagain thisandagain modified the milestones: Backlog, Beta 1/2 May 12, 2015
@toolness
Copy link
Contributor


This issue has been moved to mozilla/webmaker-core#42.
Please don't comment on it here.

@toolness toolness mentioned this issue Jul 14, 2015
Open
@toolness toolness changed the title Add icon component [MIGRATED] Add icon component Jul 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@toolness @Pomax @thisandagain @k88hudson