Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

[MIGRATED] Add user:select none wherever possible #1591

Closed
k88hudson opened this issue Apr 29, 2015 · 4 comments
Closed

[MIGRATED] Add user:select none wherever possible #1591

k88hudson opened this issue Apr 29, 2015 · 4 comments
Assignees

Comments

@k88hudson
Copy link
Contributor

We should add this to prevent accidental selection of elements/the copy paste menu popping up.

@thisandagain thisandagain modified the milestone: Alpha 2/2 Apr 29, 2015
@Pomax
Copy link
Contributor

Pomax commented Apr 29, 2015

I wonder if it makes sense to do this as a mixin, e.g.:

module.exports = {
  componentDidUpdate: function() { 
    var lnode = this.getDOMNode();
    lnode.style.userSelect = "none";
  }
}
var Thing = React.createClass({
  mixins: [
    require('unselectable')
  ],
  ...
});

Or, alternatively, set up a universal class in our LESS and wrap the classnames lib so that we can call it as:

webmakerClasses({
  ...: true,
  ...: thing.state
}, true);

and end up with the second argument determining whether text selection of content is possible or not.

@thisandagain thisandagain modified the milestones: Beta 1/2, Alpha 2/2 May 5, 2015
@thisandagain thisandagain modified the milestones: Beta 1/2, Backlog May 12, 2015
@secretrobotron
Copy link
Contributor

I was able to select some stuff in tinker mode a couple days ago.

@xmatthewx
Copy link
Contributor

Impacts destination selector as well: #2212

@toolness
Copy link
Contributor


This issue has been moved to mozilla/webmaker-core#43.
Please don't comment on it here.

@toolness toolness changed the title Add user:select none wherever possible [MIGRATED] Add user:select none wherever possible Jul 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants