This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Add travis config. All tests passing. Resolves GH-1625 #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like globbing isn't working. Here's the report on ~/Documents/mozilla-code/webmaker-android (develop) ▶ npm run test:lint
> webmaker-android@1.0.0 test:lint /Users/gsuntop/Documents/mozilla-code/webmaker-android
> jsxhint --harmony --config .jshintrc "www_src/**/*.{js,jsx}"
www_src/blocks/image.jsx: line 33, col 5, Redefinition of 'Image'.
www_src/blocks/image.jsx: line 56, col 96, Missing semicolon.
www_src/blocks/text.jsx: line 43, col 5, Redefinition of 'Text'.
www_src/blocks/text.jsx: line 62, col 53, Did you mean to return a conditional instead of an assignment?
www_src/blocks/textedit.js: line 16, col 44, Missing semicolon.
www_src/blocks/textedit.js: line 22, col 39, Expected '===' and instead saw '=='.
www_src/blocks/textedit.js: line 24, col 48, Expected '!==' and instead saw '!='.
www_src/blocks/textedit.js: line 38, col 11, Missing semicolon.
www_src/blocks/textedit.js: line 70, col 30, Expected '{' and instead saw 'return'.
www_src/components/color-group/color-group.jsx: line 20, col 25, Expected '{' and instead saw 'this'.
www_src/components/color-group/color-group.jsx: line 39, col 10, Missing semicolon.
www_src/components/option-panel/option-panel.jsx: line 42, col 16, Label 'linkState' on this statement.
www_src/components/option-panel/option-panel.jsx: line 42, col 21, Expected an assignment or function call and instead saw an expression.
www_src/components/option-panel/option-panel.jsx: line 42, col 30, Missing semicolon.
www_src/components/option-panel/option-panel.jsx: line 54, col 16, Label 'linkState' on this statement.
www_src/components/option-panel/option-panel.jsx: line 54, col 21, Expected an assignment or function call and instead saw an expression.
www_src/components/option-panel/option-panel.jsx: line 54, col 30, Missing semicolon.
www_src/components/range/range.jsx: line 3, col 5, Redefinition of 'Range'.
www_src/components/tabs/tabs.jsx: line 25, col 143, Missing semicolon.
www_src/components/tabs/tabs.jsx: line 34, col 78, Missing semicolon.
www_src/lib/api.js: line 44, col 34, Expected '{' and instead saw 'return'.
www_src/lib/api.js: line 49, col 26, Expected '{' and instead saw 'return'.
www_src/lib/cartesian.js: line 113, col 11, 'edges' is defined but never used.
www_src/lib/spec.js: line 17, col 46, Expected '{' and instead saw 'result'.
www_src/lib/spec.js: line 28, col 61, Expected '{' and instead saw 'throw'.
www_src/lib/spec.js: line 30, col 14, Expected '{' and instead saw 'throw'.
www_src/lib/spec.js: line 33, col 2, Unnecessary semicolon.
www_src/lib/spec.js: line 86, col 53, Expected '{' and instead saw 'result'.
www_src/lib/spec.js: line 95, col 57, Expected '{' and instead saw 'result'.
www_src/lib/spec.js: line 107, col 29, Expected '{' and instead saw 'element'.
www_src/lib/spec.js: line 111, col 58, Expected '{' and instead saw 'element'.
www_src/lib/spec.js: line 128, col 29, Expected '{' and instead saw 'element'.
www_src/lib/spec.js: line 133, col 58, Expected '{' and instead saw 'element'.
www_src/lib/url-pattern.js: line 3, col 55, Expected '!==' and instead saw '!='.
www_src/lib/url-pattern.js: line 6, col 28, Did you mean to return a conditional instead of an assignment?
www_src/lib/url-pattern.js: line 8, col 29, Did you mean to return a conditional instead of an assignment?
www_src/lib/url-pattern.js: line 33, col 17, Expected '===' and instead saw '=='.
www_src/lib/url-pattern.js: line 44, col 19, Expected '===' and instead saw '=='.
www_src/lib/url-pattern.js: line 47, col 25, Expected '!==' and instead saw '!='.
www_src/lib/url-pattern.js: line 86, col 20, Did you mean to return a conditional instead of an assignment?
www_src/lib/url-pattern.js: line 94, col 20, Did you mean to return a conditional instead of an assignment?
www_src/lib/url-pattern.js: line 137, col 24, Did you mean to return a conditional instead of an assignment?
www_src/lib/url-pattern.js: line 3, col 42, 'define' is not defined.
www_src/lib/url-pattern.js: line 4, col 12, 'define' is not defined.
www_src/pages/discover/discover.jsx: line 3, col 5, 'api' is defined but never used.
www_src/pages/element/element.jsx: line 27, col 15, Expected '{' and instead saw 'element'.
www_src/pages/element/element.jsx: line 54, col 16, Expected '{' and instead saw 'console'.
www_src/pages/element/element.jsx: line 63, col 16, Expected '{' and instead saw 'return'.
www_src/pages/element/element.jsx: line 64, col 35, Expected '{' and instead saw 'return'.
www_src/pages/element/element.jsx: line 72, col 41, Expected '{' and instead saw 'return'.
www_src/pages/element/element.jsx: line 77, col 18, Expected '{' and instead saw 'props'.
www_src/pages/element/image-editor.jsx: line 4, col 5, Redefinition of 'Range'.
www_src/pages/element/image-editor.jsx: line 63, col 25, Expected '{' and instead saw 'window'.
www_src/pages/element/image-editor.jsx: line 67, col 25, Expected '{' and instead saw 'window'.
www_src/pages/element/image-editor.jsx: line 5, col 5, 'Alert' is defined but never used.
www_src/pages/element/link-editor.jsx: line 6, col 5, Redefinition of 'Range'.
www_src/pages/element/text-editor.jsx: line 6, col 5, Redefinition of 'Range'.
www_src/pages/element/text-editor.jsx: line 2, col 5, 'defaults' is defined but never used.
www_src/pages/element/text-editor.jsx: line 3, col 5, 'render' is defined but never used.
www_src/pages/element/text-editor.jsx: line 6, col 5, 'Range' is defined but never used.
www_src/pages/make/make.jsx: line 26, col 16, Expected '{' and instead saw 'return'.
www_src/pages/make/make.jsx: line 27, col 36, Expected '{' and instead saw 'return'.
www_src/pages/make/make.jsx: line 46, col 16, Expected '{' and instead saw 'return'.
www_src/pages/make/make.jsx: line 47, col 35, Expected '{' and instead saw 'return'.
www_src/pages/make/make.jsx: line 5, col 5, 'Link' is defined but never used.
www_src/pages/page/page.jsx: line 159, col 18, Expected '{' and instead saw 'console'.
www_src/pages/page/page.jsx: line 174, col 64, Did you mean to return a conditional instead of an assignment?
www_src/pages/page/page.jsx: line 183, col 42, Expected '{' and instead saw 'return'.
www_src/pages/page/page.jsx: line 188, col 32, Expected '{' and instead saw 'return'.
www_src/pages/page/page.jsx: line 191, col 16, Expected '{' and instead saw 'return'.
www_src/pages/page/page.jsx: line 206, col 32, Expected '{' and instead saw 'return'.
www_src/pages/page/page.jsx: line 211, col 32, Expected '{' and instead saw 'return'.
www_src/pages/page/page.jsx: line 220, col 16, Expected '{' and instead saw 'return'.
www_src/pages/page/page.jsx: line 221, col 32, Expected '{' and instead saw 'return'.
www_src/pages/page/page.jsx: line 246, col 18, Expected '{' and instead saw 'return'.
www_src/pages/page/page.jsx: line 247, col 37, Expected '{' and instead saw 'console'.
www_src/pages/page/page.jsx: line 188, col 39, 'alert' is not defined.
www_src/pages/page/page.jsx: line 6, col 5, 'uuid' is defined but never used.
www_src/pages/page/page.jsx: line 50, col 9, 'currentElementType' is defined but never used.
www_src/pages/page/page.jsx: line 216, col 9, 'id' is defined but never used.
www_src/pages/page/positionable.jsx: line 21, col 33, Expected '{' and instead saw 'return'.
www_src/pages/page/positionable.jsx: line 68, col 32, Expected '{' and instead saw 'this'.
www_src/pages/page/positionable.jsx: line 41, col 9, 'dims' is defined but never used.
www_src/pages/page/touchhandler.js: line 44, col 45, Expected '{' and instead saw 'return'.
www_src/pages/page/touchhandler.js: line 63, col 38, Expected '{' and instead saw 'positionable'.
www_src/pages/page/touchhandler.js: line 74, col 37, Expected '{' and instead saw 'return'.
www_src/pages/page/touchhandler.js: line 98, col 37, Expected '{' and instead saw 'return'.
www_src/pages/page/touchhandler.js: line 119, col 38, Expected '{' and instead saw 'return'.
www_src/pages/page/touchhandler.js: line 125, col 4, Unnecessary semicolon.
www_src/pages/project/project.jsx: line 34, col 32, Expected '{' and instead saw 'return'.
www_src/pages/project/project.jsx: line 83, col 25, Expected '{' and instead saw 'window'.
www_src/pages/project/project.jsx: line 128, col 69, Missing semicolon.
www_src/pages/project/project.jsx: line 149, col 23, Expected '{' and instead saw 'return'.
www_src/pages/project/project.jsx: line 155, col 49, Expected '{' and instead saw 'state'.
www_src/pages/project/project.jsx: line 157, col 74, Expected an assignment or function call and instead saw an expression.
www_src/pages/project/project.jsx: line 189, col 8, Missing semicolon.
www_src/pages/project/project.jsx: line 191, col 36, Expected '{' and instead saw 'return'.
www_src/pages/project/project.jsx: line 261, col 18, Expected '{' and instead saw 'return'.
www_src/pages/project/project.jsx: line 262, col 34, Expected '{' and instead saw 'return'.
www_src/pages/project/project.jsx: line 283, col 32, Expected '{' and instead saw 'index'.
www_src/pages/project/project.jsx: line 285, col 39, Expected '{' and instead saw 'return'.
www_src/pages/project/project.jsx: line 288, col 40, Expected '{' and instead saw 'return'.
www_src/pages/project/project.jsx: line 295, col 16, Expected '{' and instead saw 'return'.
www_src/pages/project/project.jsx: line 288, col 47, 'alert' is not defined.
www_src/pages/project/project.jsx: line 9, col 5, 'Link' is defined but never used.
www_src/pages/project/project.jsx: line 125, col 11, 'center' is defined but never used.
www_src/pages/project/project.jsx: line 207, col 9, 'params' is defined but never used.
www_src/pages/project/project.jsx: line 248, col 11, 'params' is defined but never used.
www_src/pages/style-guide/style-guide.jsx: line 7, col 5, Redefinition of 'Range'.
www_src/pages/style-guide/style-guide.jsx: line 34, col 38, Missing semicolon.
www_src/pages/tinker/tinker.jsx: line 7, col 5, Redefinition of 'Range'.
www_src/tests/spec.test.js: line 121, col 9, Missing semicolon.
www_src/tests/spec.test.js: line 130, col 9, Missing semicolon.
www_src/tests/spec.test.js: line 20, col 1, 'describe' is not defined.
www_src/tests/spec.test.js: line 22, col 3, 'it' is not defined.
www_src/tests/spec.test.js: line 27, col 3, 'it' is not defined.
www_src/tests/spec.test.js: line 32, col 3, 'it' is not defined.
www_src/tests/spec.test.js: line 37, col 3, 'it' is not defined.
www_src/tests/spec.test.js: line 42, col 3, 'it' is not defined.
www_src/tests/spec.test.js: line 48, col 3, 'describe' is not defined.
www_src/tests/spec.test.js: line 49, col 5, 'it' is not defined.
www_src/tests/spec.test.js: line 53, col 5, 'it' is not defined.
www_src/tests/spec.test.js: line 56, col 5, 'it' is not defined.
www_src/tests/spec.test.js: line 61, col 5, 'it' is not defined.
www_src/tests/spec.test.js: line 68, col 3, 'describe' is not defined.
www_src/tests/spec.test.js: line 70, col 5, 'it' is not defined.
www_src/tests/spec.test.js: line 75, col 3, 'describe' is not defined.
www_src/tests/spec.test.js: line 76, col 5, 'it' is not defined.
www_src/tests/spec.test.js: line 94, col 3, 'describe' is not defined.
www_src/tests/spec.test.js: line 97, col 5, 'beforeEach' is not defined.
www_src/tests/spec.test.js: line 115, col 5, 'describe' is not defined.
www_src/tests/spec.test.js: line 116, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 124, col 5, 'describe' is not defined.
www_src/tests/spec.test.js: line 125, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 133, col 5, 'describe' is not defined.
www_src/tests/spec.test.js: line 134, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 138, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 151, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 165, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 171, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 179, col 5, 'describe' is not defined.
www_src/tests/spec.test.js: line 180, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 184, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 197, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 217, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 228, col 5, 'describe' is not defined.
www_src/tests/spec.test.js: line 229, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 241, col 7, 'it' is not defined.
www_src/tests/spec.test.js: line 24, col 11, 's' is defined but never used.
www_src/tests/spec.test.js: line 29, col 11, 's' is defined but never used.
www_src/tests/spec.test.js: line 34, col 11, 's' is defined but never used.
www_src/tests/spec.test.js: line 39, col 11, 's' is defined but never used.
www_src/tests/spec.test.js: line 44, col 11, 's' is defined but never used.
153 errors |
|
@gvn Ok ... I've got this down to nine errors, but I'm really scratching my head on these last few. Do you mind if we land this before too many more merge conflicts pop up? |
|
Yeah, go for it! |
thisandagain
added a commit
that referenced
this pull request
May 21, 2015
Add travis config. All tests passing. Resolves GH-1625
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.