Skip to content
This repository has been archived by the owner on Jul 16, 2018. It is now read-only.

We should nullify the "component edit" view history states once edits are committed #1304

Closed
Pomax opened this issue Feb 24, 2015 · 1 comment

Comments

@Pomax
Copy link
Contributor

Pomax commented Feb 24, 2015

Right now if you build a template, edit a component, change its values, save those changes, and then hit "back", you're taking back to the "change the values" screen, rather than to the "build the template" screen. It feels like we're doing this:

  • build template -> history.pushState
  • tap component edit button
  • get into edit view -> history.pushState
  • save change
  • get back to app view -> history.pushState
  • tap component edit button
  • get into edit view -> history.pushState
  • save change
  • get back to app view -> history.pushState

when we should probably be doing:

  • build template -> history.pushState
  • tap component edit button
  • get into edit view -> history.pushState
  • save change
  • get back to app view -> remove edit state from history
  • tap component edit button
  • get into edit view -> history.pushState
  • save change
  • get back to app view -> remove edit state from history

That way, in order to "get back" to things like the template menu, you're not first tapping "back" through however many edits you made to your app.

@Pomax
Copy link
Contributor Author

Pomax commented Feb 24, 2015

filed on the wrong repo

@Pomax Pomax closed this as completed Feb 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant