This repository has been archived by the owner on Jul 16, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 99
Integrate Angular i18n finder #1083
Merged
alicoding
merged 1 commit into
mozilla:master
from
alicoding:issue1066-update-version-grunt
Jan 15, 2015
Merged
Integrate Angular i18n finder #1083
alicoding
merged 1 commit into
mozilla:master
from
alicoding:issue1066-update-version-grunt
Jan 15, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
02908ff
to
b95b5dc
Compare
@secretrobotron or @gesa can one of you help review this? Thanks! |
</p> | ||
</div> | ||
</section> | ||
<section name="starter-apps" id="starter-apps"> | ||
<div class="container"> | ||
<p class="lead text-center">{{'Don\'t know where to start?' | i18n}}</p> | ||
<p class="lead text-center">{{ 'Don't know where to start?' | i18n }}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong. Don't need to escape the apostrophe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't like it when we do escape in the locale file @secretrobotron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh snap! I need to fix this.
|
Also, this is a bit weird:
|
nice catch @secretrobotron ! this is fixed. |
d51132d
to
55091b4
Compare
55091b4
to
924729c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add grunt angular i18n finder and making sure most of it using the right format
This way we will be able to run the grunt validate and find any missing or unused keys
To test this simply run
npm install
then rungrunt validate
Please note that there are many unused strings that next PR will cover the fix