Skip to content
This repository has been archived by the owner on Jul 16, 2018. It is now read-only.

Integrate Angular i18n finder #1083

Merged
merged 1 commit into from
Jan 15, 2015

Conversation

alicoding
Copy link
Collaborator

This patch add grunt angular i18n finder and making sure most of it using the right format
This way we will be able to run the grunt validate and find any missing or unused keys

To test this simply run npm install then run grunt validate

Please note that there are many unused strings that next PR will cover the fix

@alicoding
Copy link
Collaborator Author

@secretrobotron or @gesa can one of you help review this? Thanks!

</p>
</div>
</section>
<section name="starter-apps" id="starter-apps">
<div class="container">
<p class="lead text-center">{{'Don\'t know where to start?' | i18n}}</p>
<p class="lead text-center">{{ 'Don't know where to start?' | i18n }}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. Don't need to escape the apostrophe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't like it when we do escape in the locale file @secretrobotron

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh snap! I need to fix this.

@secretrobotron
Copy link
Contributor

Running "angular_i18n_finder:files" (angular_i18n_finder) task
>> Found unused key names in JSON provided.
>>  Please consider removing them or add to the ignoreKeys.
>>  list: [ 'Don\'t know where to start?' ]

@secretrobotron
Copy link
Contributor

Also, this is a bit weird:

Searching 9 files for "know where to start" (regex, case sensitive)

/Users/secretrobotron/src/webmaker.org/locale/en_US/appmaker.json:
    8      "description": "A short explanation for what Appmaker is"
    9    },
   10:   "Dont know where to start?": {
   11:     "message": "Don't know where to start?",
   12:     "description": "Don't know where to start?"
   13    },
   14    "Mobile apps made easy": {
   ..
   36      "description": "Title for Appmaker landing page"
   37    },
   38:   "Don't know where to start?": {
   39      "message": "Looking for an easy way to get started? Remix one of these templates to make your very own app.",
   40      "description": "Catch the imagination of users at the top of the page."

4 matches in 1 file

@alicoding
Copy link
Collaborator Author

nice catch @secretrobotron ! this is fixed.

@alicoding alicoding force-pushed the issue1066-update-version-grunt branch 2 times, most recently from d51132d to 55091b4 Compare January 15, 2015 17:03
@alicoding alicoding force-pushed the issue1066-update-version-grunt branch from 55091b4 to 924729c Compare January 15, 2015 17:04
@alicoding alicoding merged commit 924729c into mozilla:master Jan 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants