This repository has been archived by the owner on Jul 16, 2018. It is now read-only.
issue #1066 - remove unused strings #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@secretrobotron can you r? this please? :) |
6 tasks
| "DetailsShareTwitterMsg", "guide", "Info" | ||
| "DetailsShareTwitterMsg", "guide", "Info", "Did you know Webmaker is also available in", "Webmaker", "StandardFooterTranslate", | ||
| "StandardConnectingCollaboratingPoint1", "StandardConnectingCollaboratingPoint2", "StandardConnectingCollaboratingPoint3", | ||
| "StandardFooterButton", "StandardMainDesc1", "StandardMainDesc2", "StandardMainDesc3", "StandardMainHeader" |
There was a problem hiding this comment.
This is a pretty confusing situation. We need to mention things like StandardMainDesc1 here, even though it's translated by an angular filter? Can we just prevent public/views/literacy.html from being checked or something?
There was a problem hiding this comment.
yeah I think it is better to just not check for literacy.html at all...
|
r+ |
alicoding
force-pushed
the
issue1066-remove-strings
branch
from
2ad6c7f
to
7a0f294
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this patch just run
grunt validatethis should not fail on any of the unused strings at all.Please test on any of the webmaker page to see if there is any error or missing strings (displaying the key name instead of the actual string).