Skip to content
This repository has been archived by the owner on Jul 16, 2018. It is now read-only.

T1299 #1318

Merged
merged 3 commits into from Feb 24, 2015
Merged

T1299 #1318

merged 3 commits into from Feb 24, 2015

Conversation

secretrobotron
Copy link
Contributor

fixes #1299

@secretrobotron
Copy link
Contributor Author

@cadecairos r?

@secretrobotron
Copy link
Contributor Author

@gavinsharp r?

@cadecairos
Copy link
Contributor

@gvn

@cadecairos
Copy link
Contributor

a few things to clean up:

  1. The error message is visible when the form is first displayed.
  2. The message should probably not appear if the input is blurred, but empty
  3. When I blur the input I see the message twice?

@secretrobotron
sms number fixes
ccf1acf 
1. removed duplicate message
2. don't show the error if nothing is in the textbox
@secretrobotron
Copy link
Contributor Author

@cadecairos should be fine now.

@cadecairos
Copy link
Contributor

r+

secretrobotron added a commit that referenced this pull request Feb 24, 2015
@secretrobotron
Merge pull request #1318 from secretrobotron/t1299
c8e348f 
T1299
@secretrobotron secretrobotron merged commit c8e348f into mozilla:master Feb 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

US Phone number is problematic
2 participants
@secretrobotron @cadecairos