get and post api for pins (bug single-page-api) #365
Conversation
|
@muffinresearch i'll add some docs for this, is there anything else you want before an init commit, this should be safe to do and shouldn't affect anything else |
|
|
||
| def create(self, request): | ||
| res = process_pay_req(request, request.DATA) | ||
| if res: |
There was a problem hiding this comment.
If this returns a response from app_error() it will be in HTML. We could alter custom_error() to check the accept header from the request object to make it JSON. Could also file another bug and add a todo for that.
There was a problem hiding this comment.
Hah! you already did that. Nice work :)
|
Looks like this has conflicts. |
|
|
||
| # Uncomment the next line to enable the admin: | ||
| # (r'^admin/', include(admin.site.urls)), | ||
| url(r'^mozpay/api/', include('webpay.api.urls', namespace='api')), |
There was a problem hiding this comment.
Is this going to be versioned at some point?
|
now with docs |
|
just ran some tests against sentry and the PIN isn't sent through to sentry |
|
@muffinresearch what do you want me to do here? |
I don't think I need anything else for the initial commit. |
|
I'll put this behind a settings and turn off in prod and stage till its ready. |
|
I'll wait for #393 to land, because having old SPA code breaks the unit tests if we flip ENABLE_SPA to True for all tests. |
|
@andymckay #393 has landed now. |
No description provided.