Upgrade to mainline PyJWT (part of bug 1145024) #620
Conversation
| @@ -87,7 +96,8 @@ def req_ok(req): | |||
| eq_(dd['typ'], payload['typ']) | |||
| eq_(dd['response']['price']['amount'], 1) | |||
| eq_(dd['response']['price']['currency'], u'USD') | |||
| jwt.decode(req['notice'], 'f', verify=True) | |||
| jwt.decode(req['notice'], 'f', verify=True, | |||
| audience=self.payment_issuer) | |||
There was a problem hiding this comment.
I'm a little paranoid so I'd rather see audience='some-apps-public-id' here.
There was a problem hiding this comment.
I think as long as it's different from the default than it should be pretty robust
|
I don't remember why we were using PyJWT-mozilla before but seemingly that has been addressed? Hopefully this fixes the I'd like to the the actual string that's being used in the tests rather than I'm not sure if this catches all the places it needs to, and I don't think there are any integration tests here. Is there some way integration tests could be added? (In a separate patch). |
|
r+wc |
|
The mozwebQA team has integration tests for the payment flows. When it lands on dev I will check with them. There never was a great reason for why we used PyJWT-mozilla. We needed some security patches but didn't have luck integrating them upstream so we forked it. However, PyJWT has since got a new maintainer and it is very active now. |
This switches us from PyJWT-mozilla to PyJWT which is more maintained and has more features now. This doesn't introduce any new functionality but to use the new PyJWT we also needed a mozpay-py upgrade.
Upgrade to mainline PyJWT (part of bug 1145024)
This switches us from PyJWT-mozilla to PyJWT which
is more maintained and has more features now.
This doesn't introduce any new functionality but
to use the new PyJWT we also needed a mozpay-py upgrade.