This repository has been archived by the owner on Jan 25, 2018. It is now read-only.
Update sign-in copy (bug 863462) (Don't merge just yet) #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ |
| data-terms-of-service="https://marketplace.firefox.com/terms-of-use" | ||
|
|
||
| data-privacy-policy="{{ settings.PRIVACY_POLICY_URL }}" | ||
| data-terms-of-service="{{ settings.TERMS_URL }}" |
There was a problem hiding this comment.
heh, I didn't know that was hard coded
|
r+wc |
|
Just noticed some issues with this on device re: what happens when you click the links on b2g. So waiting for an update before landing https://bugzilla.mozilla.org/show_bug.cgi?id=863462#c2 |
|
Closing this as the terms / privacy policy are shown on the persona side. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the sign-in page copy to match the mock.
Let me know if there's a better way to handle the links in the translation string.