Remove cloning #106
Remove cloning #106
Conversation
|
@na-g it's not fully at what we talked about it, but hopefully a step in the right direction. What do you think? |
| }); | ||
| } | ||
| // the line parsers throw unsupported errors for these already | ||
| SdpType::Email(_) |
There was a problem hiding this comment.
If these SDP types throw parsing errors, then they should be removed from the enum, and that way we don't have to worry about illegal state everywhere we use this enum. This follows the '"make the impossible inexpressible" rule of thumb. That could be handled in another bug though.
There was a problem hiding this comment.
Excellent idea. I created issue #107 for that!
src/lib.rs
Outdated
| @@ -1011,7 +1026,7 @@ pub fn parse_sdp(sdp: &str, fail_on_warning: bool) -> Result<SdpSession, SdpPars | |||
| line_number: 0, | |||
| }); | |||
| } | |||
| if sdp.len() < 62 { | |||
| if sdp.len() < 40 { | |||
| return Err(SdpParserError::Line { | |||
| error: SdpParserInternalError::Generic("string to short to be valid SDP".to_string()), | |||
There was a problem hiding this comment.
"string to short" -> "string too short"
There was a problem hiding this comment.
Thanks. Fixed.
Ha, awesome. Yes another clone() call gone. Thank you! |
Improved proper ownership and removed as many direct clone() calls as possible.