-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
I'll create a temporary heroku app for this. |
Thank you! |
include:markdown markdown/clubs/cta.md | ||
a.btn.btn-white(href='https://learning.mozilla.org/clubs') Learn More | ||
|
||
.container.m-y-2 | ||
.container.m-y-3.our-work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the class wrappers around partials I've been using the namespace convention partial-PARTIALNAMEHERE
so that we don't have collisions later if and when we add more pages.
We should use
|
|
All partner logos should be SVG or PNG. |
@flukeout This is looking great. Just some various fixes & tweaks! 👍 |
@gvn curious about rationale for...
Otherwise, all linting is complete! Thanks for the thorough review. |
Added reports and updated run & build commands Fixed link Updated styling for PDF links Nukedit
@gideonthomas removed |
@flukeout ok I'll merge it in. Thank you! |
Cool thanks! |
Any low-color image should be SVG or PNG because JPEG is for photos. SVG and PNG compress low color imagery way better, so file size & quality are the reasons.
They are very large as PNGs (over 200k each). As JPEGs they can be a fraction of that size. |
Styled the page to match the designs in the redpen and added in the missing content.
In addition to a code review, can we move this into some kind of staging environment so that we can start a QA process for content and design.
cc @gideonthomas