Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

Content and styling updates #27

Merged
merged 1 commit into from
Aug 31, 2016
Merged

Content and styling updates #27

merged 1 commit into from
Aug 31, 2016

Conversation

flukeout
Copy link
Contributor

Styled the page to match the designs in the redpen and added in the missing content.

In addition to a code review, can we move this into some kind of staging environment so that we can start a QA process for content and design.

cc @gideonthomas

@gideonthomas
Copy link
Contributor

I'll create a temporary heroku app for this.

@flukeout
Copy link
Contributor Author

Thank you!

include:markdown markdown/clubs/cta.md
a.btn.btn-white(href='https://learning.mozilla.org/clubs') Learn More

.container.m-y-2
.container.m-y-3.our-work
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the class wrappers around partials I've been using the namespace convention partial-PARTIALNAMEHERE so that we don't have collisions later if and when we add more pages.

@gvn
Copy link
Contributor

gvn commented Aug 29, 2016

The logos look kinda funky for mobile:

screen shot 2016-08-29 at 10 50 06 am

@gvn
Copy link
Contributor

gvn commented Aug 29, 2016

We should use px as little as possible for responsive layouts. rem is what should be used instead.

em is ok if you truly want something expressed based relative to a font size (eg: typography).

@gvn
Copy link
Contributor

gvn commented Aug 29, 2016

classroom-bg.png and header-bg.png should be JPEGs. Can you add opacity via CSS?

@gvn
Copy link
Contributor

gvn commented Aug 29, 2016

All partner logos should be SVG or PNG.

@gvn
Copy link
Contributor

gvn commented Aug 29, 2016

@flukeout This is looking great. Just some various fixes & tweaks! 👍

@flukeout
Copy link
Contributor Author

@gvn curious about rationale for...

  • All partner logos should be SVG or PNG.
  • classroom-bg.png and header-bg.png should be JPEGs

Otherwise, all linting is complete! Thanks for the thorough review.

Added reports and updated run & build commands

Fixed link

Updated styling for PDF links

Nukedit
@flukeout
Copy link
Contributor Author

@gideonthomas removed procfile

@gideonthomas
Copy link
Contributor

@flukeout ok I'll merge it in. Thank you!

@gideonthomas gideonthomas merged commit 93c6880 into mozilla:master Aug 31, 2016
@flukeout
Copy link
Contributor Author

Cool thanks!

@gvn
Copy link
Contributor

gvn commented Sep 1, 2016

All partner logos should be SVG or PNG.

Any low-color image should be SVG or PNG because JPEG is for photos. SVG and PNG compress low color imagery way better, so file size & quality are the reasons.

classroom-bg.png and header-bg.png should be JPEGs

They are very large as PNGs (over 200k each). As JPEGs they can be a fraction of that size.

@flukeout flukeout deleted the style-and-content branch September 1, 2016 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants