Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

Commit

Permalink
Updated ids.json to match FirefoxOS (bug 870920)
Browse files Browse the repository at this point in the history
  • Loading branch information
robhudson committed May 10, 2013
1 parent 7b8ae84 commit 49437a2
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions apps/files/models.py
Expand Up @@ -497,17 +497,17 @@ def inject_ids(self):
"""
For packaged webapps, adds a META-INF/ids.json file with a JSON
document like the following:
{"app_id": "6106d3b3-881a-4ddf-9dec-6b2bf8ff8341",
"version_id": 42}
{"id": "6106d3b3-881a-4ddf-9dec-6b2bf8ff8341",
"version": 42}
"""
app = self.version.addon
if not (app.type == amo.ADDON_WEBAPP and app.is_packaged):
return

filename = 'META-INF/ids.json'
ids = {
'app_id': app.guid,
'version_id': self.version_id,
'id': app.guid,
'version': self.version_id,
}
zf = SafeUnzip(self.file_path, mode='a')
zf.is_valid()
Expand Down
4 changes: 2 additions & 2 deletions mkt/developers/tests/test_views_versions.py
Expand Up @@ -213,8 +213,8 @@ def test_new_version_gets_ids_file(self, _mock):
assert zf.getinfo(filename), (
'Expected %s in zip archive but not found.' % filename)
ids = json.loads(zf.read(filename))
eq_(ids['app_id'], self.app.guid)
eq_(ids['version_id'], file_.version_id)
eq_(ids['id'], self.app.guid)
eq_(ids['version'], file_.version_id)


class TestEditVersion(amo.tests.TestCase):
Expand Down
4 changes: 2 additions & 2 deletions mkt/submit/tests/test_views.py
Expand Up @@ -524,8 +524,8 @@ def test_packaged_app_has_ids_file(self):
assert zf.getinfo(filename), (
'Expected %s in zip archive but not found.' % filename)
ids = json.loads(zf.read(filename))
eq_(ids['app_id'], app.guid)
eq_(ids['version_id'], file_.version_id)
eq_(ids['id'], app.guid)
eq_(ids['version'], file_.version_id)


class TestDetails(TestSubmit):
Expand Down

0 comments on commit 49437a2

Please sign in to comment.