Exclude themes from compat validation (bug 776160)

mozilla · Jul 31, 2012 · 973fee9 · 973fee9
1 parent aab3ff4
commit 973fee9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/apps/zadmin/tests/test_views.py b/apps/zadmin/tests/test_views.py
@@ -280,6 +280,18 @@ def test_ignore_lang_packs(self, bulk_validate_file):
         assert not bulk_validate_file.delay.called, (
                         'Lang pack addons should be ignored')
 
+    @mock.patch('zadmin.tasks.bulk_validate_file')
+    def test_ignore_themes(self, bulk_validate_file):
+        target_ver = self.appversion('3.7a3').id
+        self.addon.update(type=amo.ADDON_THEME)
+        self.client.post(reverse('zadmin.start_validation'),
+                         {'application': amo.FIREFOX.id,
+                          'curr_max_version': self.curr_max.id,
+                          'target_version': target_ver,
+                          'finish_email': 'fliggy@mozilla.com'})
+        assert not bulk_validate_file.delay.called, (
+                        'Theme addons should be ignored')
+
     @mock.patch('zadmin.tasks.bulk_validate_file')
     def test_validate_all_non_disabled_addons(self, bulk_validate_file):
         target_ver = self.appversion('3.7a3').id

diff --git a/apps/zadmin/views.py b/apps/zadmin/views.py
@@ -213,7 +213,9 @@ def find_files(job):
                         versions__apps__application=job.application.id,
                         versions__apps__max__version_int__gte=current,
                         versions__apps__max__version_int__lt=target)
-                           .exclude(type=amo.ADDON_LPAPP)  # no langpacks
+                           # Exclude lang packs and themes.
+                           .exclude(type__in=[amo.ADDON_LPAPP,
+                                              amo.ADDON_THEME])
                            .no_transforms().values_list("pk", flat=True)
                            .distinct())
     for pks in chunked(addons, 100):