Fix leaked JNI local references in GeckoSurfaceTexture (#2772)

MozillaReality · Feb 10, 2020 · 42892aa · 42892aa
1 parent 26417bc
commit 42892aa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/app/src/main/cpp/ExternalBlitter.cpp b/app/src/main/cpp/ExternalBlitter.cpp
@@ -160,6 +160,7 @@ ExternalBlitter::CancelFrame(const int32_t aSurfaceHandle) {
     surface = iter->second;
   } else {
     surface = GeckoSurfaceTexture::Create(aSurfaceHandle);
+    m.surfaceMap[aSurfaceHandle] = surface;
   }
 
   if (surface) {

diff --git a/app/src/main/cpp/GeckoSurfaceTexture.cpp b/app/src/main/cpp/GeckoSurfaceTexture.cpp
@@ -137,6 +137,7 @@ GeckoSurfaceTexture::Create(const int32_t aHandle) {
   }
   result = std::make_shared<vrb::ConcreteClass<GeckoSurfaceTexture, GeckoSurfaceTexture::State> >();
   result->m.surface = sEnv->NewGlobalRef(surface);
+  sEnv->DeleteLocalRef(surface);
   result->IncrementUse();
   return result;
 }