Skip to content

Commit

Permalink
Multiwindow implementation (#1467)
Browse files Browse the repository at this point in the history
* Remove unused code

* Sessions Multiwindow implementation

Refactor of the current sessions code and added support for multi window.

* Implement window placement logic

* Refactored session settings to SessionManager

Always update all session when a session settings changes

* Keyboard multiwindow placement

* Added support for browser context menus

* Context Menu integration

* Fix parenting bug with three window moves

* Fix relayout on window resize. Set up better anchor points for left/right window resizes.

* Fixed Bookmarks navigation

Also added support for bookmarks in all the windows as stated in the spec: #1331

* Close sessions when a window is closed

Now when a window it's closed it's underlying sessions are closed.

* Add new tray icons

* Session restore


wip

* Fix resize gesture flickering and conflicts.

* Added support for restoring private sessions

* Save and restore window sizes

* Set up max reside sizes for multiwindow

* Exit fullscreen when window is closed

Also fixed a regression that made session not to close when a window is closed

* Fix fullscreen mode: hide other windows and make the fullscreened window the front one

* Fixed ADB issue and double loadUri when restoring windows.

* Make max windows dialog match  spec

* Curved mode fixes

* Fix rebase issues

* Fix cylindrical mode math for multiwindow.

* Fixed performance monitor from rebase and added missing tooltips

* Rebase fixes

* New Settings spec rebase fixes

* Added User-Agent multi-window support and fixed session restore issues

The home page was being loaded after a session restore. Now the home page is only loaded if the session is not restored. Also fixed some session restore issues to also restore session settings.

* Fix Tasckluster NoApi compilation issue

* Fixed context menu issues

* More ContextMenu fixes

* Fixed move window buttons get stuck in hover state

Fixes #1482

* Disable left/right move buttons when in private mode single window

* Multi-window Telemetry (#1443)

* Remove unneeded switchBookmarks call which causes a surface resize each time windows are updated

* Dime out world when closing a window

* Rebase fixes

* SessionStore rename

* Fix for session restore in WaveVR

* Fix movable keyboard for multiwindow

* Rebase fixes
  • Loading branch information
MortimerGoro authored and bluemarvin committed Aug 2, 2019
1 parent 2809aee commit f76f19d
Show file tree
Hide file tree
Showing 94 changed files with 3,941 additions and 1,520 deletions.
3 changes: 2 additions & 1 deletion app/build.gradle
Expand Up @@ -94,7 +94,7 @@ android {
}

lintOptions {
disable "LogUsage", "ExtraTranslation"
disable "ExtraTranslation"
}

packagingOptions {
Expand Down Expand Up @@ -428,6 +428,7 @@ dependencies {
implementation deps.support.vector_drawable
implementation deps.support.annotations
implementation deps.constraint_layout
implementation deps.gson

// Android Components
implementation deps.mozilla_speech
Expand Down
16 changes: 7 additions & 9 deletions app/src/common/shared/org/mozilla/vrbrowser/DataRepository.java
@@ -1,21 +1,19 @@
package org.mozilla.vrbrowser;

import android.content.Context;

import org.mozilla.vrbrowser.browser.SessionStore;
import org.mozilla.vrbrowser.db.AppDatabase;
import org.mozilla.vrbrowser.db.entity.BookmarkEntity;
import org.mozilla.vrbrowser.model.Bookmark;

import java.util.List;

import androidx.annotation.NonNull;
import androidx.lifecycle.Lifecycle;
import androidx.lifecycle.LifecycleOwner;
import androidx.lifecycle.LifecycleRegistry;
import androidx.lifecycle.LiveData;
import androidx.lifecycle.MediatorLiveData;

import org.mozilla.vrbrowser.browser.engine.SessionStore;
import org.mozilla.vrbrowser.db.AppDatabase;
import org.mozilla.vrbrowser.db.entity.BookmarkEntity;
import org.mozilla.vrbrowser.model.Bookmark;

import java.util.List;

public class DataRepository implements LifecycleOwner {

private static DataRepository sInstance;
Expand Down

0 comments on commit f76f19d

Please sign in to comment.