Focus Plus support #1149
Focus Plus support #1149
Conversation
|
@bluemarvin Nice work, thanks for leading this. |
bluemarvin
force-pushed
the
focus-plus
branch
5 times, most recently
from
43bdded
to
927b7da
Compare
| delegate->SetButtonState(index, ControllerDelegate::BUTTON_APP, -1, menuPressed, menuPressed); | ||
|
|
||
|
|
| @@ -324,14 +334,18 @@ DeviceDelegateWaveVR::ReleaseControllerDelegate() { | |||
|
|
|||
| int32_t | |||
| DeviceDelegateWaveVR::GetControllerModelCount() const { | |||
| return 1; | |||
| return 2; | |||
There was a problem hiding this comment.
I think even on Focus Plus, the model count still should be one. In Oculus Quest
if (m.IsOculusQuest()) {
return 2;
} else {
return 1;
}
It exactly uses two controller models.
There was a problem hiding this comment.
Oculus has an API to know what device you are on, from what I can tell Wave does not.
| } else if (aModelIndex == 1) { | ||
| return "focus_plus.obj"; | ||
| } | ||
|
|
There was a problem hiding this comment.
It looks like we should change it to
if (!m.Is6Dof()) { // or !IsFocusPlus().
return "vr_controller_focus.obj";
} else if (aModelIndex == 1) {
return "focus_plus.obj";
}
We were using aModelIndex is because Quest has two kinds of controller models.
There was a problem hiding this comment.
The fact that the controller can change from 3DoF to 6DoF while running makes this a different situation from the Quest.
To reset view press and hold the grip button.