This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Make No internet dialog and transport controls not to collide #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
approved these changes
Nov 13, 2019
bluemarvin
reviewed
Nov 13, 2019
MortimerGoro
approved these changes
Nov 14, 2019
app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/NoInternetWidget.java
Outdated
Show resolved
Hide resolved
MortimerGoro
approved these changes
Nov 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1975 Moving the No Internet dialog in front of the transport controls makes it too close to the user. Instead of that we hide the transport controls when the no internet dialog is displayed. If the user clicks in the video while the no internet dialog is visible, it dismisses it and the transport controls are displayed again.
Also added a listener for the connectivity status so we can eventually listen to that events from any widget.