New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #672 Downloads support #3072
Conversation
Seems pretty good. Not sure I like the badge. I also find the save location of internal or external confusing. I have no idea where that would be if I went looking for the files on the device if I were to mount it. |
Updated with final design: https://trello.com/c/iBLotKN4 |
The spec also has the download progress like on desktop with a blue badge after download is complete. |
Not sure why you don't see them but both things you mentioned were already there in the last push. I've forced push again and fixed and issue I was seeing with clipping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Download window fails to show if page creates a new tab. STR:
- go to https://community-tc.services.mozilla.com/tasks/Vl6vfgK4Ti6y9M1aMl65rQ#artifacts
- click on one of the APKs and start download
- click download button from tray
Actual:
Nothing happens
Expected:
Download window is opened.
94b584e
to
939fcc3
Compare
@bluemarvin seems to be related to the firstpaint issue. |
Which first paint issue? Has it been fixed in master because I rebased and am still seeing the issue. |
@bluemarvin I didn't have time to fix the firstpaint issue today but what you see here it's related to that. You can also reproduce it if you open a new tab in the background from the context menu and switch to that tab. |
19607bc
to
273c691
Compare
Closes #672 This PR adds Downloads support. Some refactoring has been done to take all the Library panels logic out from the Window class.
Waiting for final design.