Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make setupListener calls safer #3277

Closed
MortimerGoro opened this issue Apr 28, 2020 · 0 comments · Fixed by #3297
Closed

Make setupListener calls safer #3277

MortimerGoro opened this issue Apr 28, 2020 · 0 comments · Fixed by #3297
Assignees
@keianhzo
Labels
in progress
Milestone
#11 polish

Comments

@MortimerGoro
Copy link
Contributor

See:
#3265 (review)
@MortimerGoro MortimerGoro added this to the #11 polish milestone Apr 28, 2020
@keianhzo keianhzo mentioned this issue Apr 30, 2020
Merged
bluemarvin pushed a commit that referenced this issue May 28, 2020
@keianhzo
Closes #3277 Improved setSession code (#3297)
05537c3 
* Improved set session code


Simplify setActive to only deactivate the old session


Use state for setActive

* Deactivate current session when a tab is received
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keianhzo keianhzo

Labels
in progress
Projects
None yet
Milestone
#11 polish
Development

Successfully merging a pull request may close this issue.

Closes #3277 Improved setSession code MozillaReality/FirefoxReality
2 participants
@keianhzo @MortimerGoro