Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v2 to v3 Database migration #3334

Merged
merged 1 commit into from May 5, 2020
Merged

Fix v2 to v3 Database migration #3334

merged 1 commit into from May 5, 2020

Conversation

MortimerGoro
Copy link
Contributor

Fixes #3329

@MortimerGoro MortimerGoro self-assigned this May 5, 2020
@MortimerGoro MortimerGoro added this to the #10 features milestone May 5, 2020
@bluemarvin
Copy link
Contributor

This didn't work for me. FxR crashes when trying to run v10 for the first time after using v9 to create a popup exception.

@MortimerGoro
Copy link
Contributor Author

Ready for testing again. There was a conflict between different types and the allowed column. Unfortunately SQLite doesn't support column remove without the mess of deleting a recreating the whole table, so it's easier to keep it. We can rename it in the future if we add a boolean field

@bluemarvin bluemarvin merged commit 37a3f8b into master May 5, 2020
@bluemarvin bluemarvin deleted the v10/database_migration branch May 5, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

Assignees

@MortimerGoro MortimerGoro

Labels
None yet
Projects
None yet
Milestone
#10 features
Development

Successfully merging this pull request may close these issues.

The pop-up exceptions list is not saved when updating FxR from V9 to V10
2 participants
@MortimerGoro @bluemarvin